Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release a madge version to solve "Not all imports in TypeScript are detected" #402

Closed
fcsonline opened this issue Feb 15, 2024 · 6 comments

Comments

@fcsonline
Copy link

We have been facing some problem to detect all the dependencies from our project, and we have seen that are related to skipped files in madge.

There is an issue in this repository with the title "Not all imports in TypeScript are detected" marked as resolved, but the problem persists as there are some users reporting the same behaviour as we are facing:
#128
#128 (comment)

It seems that the culprit of the problem was an issue in node-filing-cabinet and as consequence also in node-dependency-tree (10.*.*) that was solved months ago.

It looks like you are properly solved in main branch in madge but these changes have not been release in a proper NPM release, because the latest version 6.1.0 uses the buggy version.

We can use the workaround of using the git npm dependency, but it would be awesome to release a madge version to fix definitely this issue.

This was referenced Feb 15, 2024
@0kzh
Copy link

0kzh commented Feb 27, 2024

Please! Tracing this bug was a pain

@kainosnoema
Copy link

Yes! We've been fighting with this for months, finally figured out that it was already fixed in main. Please release a new version @pahen. 🙏

@cvoege
Copy link

cvoege commented Apr 5, 2024

@pahen Are you still interested in maintaining this library? If not, would you be interested in passing it's stewardship along to another?

@pahen
Copy link
Owner

pahen commented Apr 8, 2024

@pahen Are you still interested in maintaining this library? If not, would you be interested in passing it's stewardship along to another?

No, I'm not interested in maintaining this library anymore, see #334

But I created a new major version and published it to NPM now :)

@pahen pahen closed this as completed Apr 8, 2024
@cvoege
Copy link

cvoege commented Apr 10, 2024

@pahen Thank you! We all appreciate your contributions to open source very much!

@fcsonline
Copy link
Author

Thank you so much @pahen for the release and for all the effort in this library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants