Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some collaborator to maintain this package #334

Open
PabloLION opened this issue Nov 16, 2022 · 20 comments
Open

Add some collaborator to maintain this package #334

PabloLION opened this issue Nov 16, 2022 · 20 comments
Labels
dev dev-related topic of this repo

Comments

@PabloLION
Copy link
Collaborator

As discussed in #319 (comment), this repo is currently down for maintenance and we have 0 issue solved / PR merged in the last month (See here https://github.com/pahen/madge/pulse/monthly)

I believe that this repo needs some helping hands from the community. As I have no experience maintaining any popular package, maybe some more senior ones can help with this?

@kamiazya
Copy link
Collaborator

Hi, @pahen @PabloLION

I became interested in this project through developing #341 and discovered this issue while researching.

I am not sure if I am qualified to be a maintainer for a project of this size, but I may be able to help since I develop some npm library.

I can't commit to helping forever either, but how about trying to help out by focusing on maintaining?

Since I can't see the status of my work and personal activities yet, I will try to volunteer until the end of March 2023 to work on fixing high priority bugs like Node.js 18 support.

(It would be beneficial for me to contribute to this project, especially since getting #341 merged will increase the use of my project.)

Thanks.

@PabloLION
Copy link
Collaborator Author

Hi @kamiazya . I'm happy to see that someone can help maintaining this, but I can't do anything. Maybe you can create a fork?
I do remember that @pahen , the owner, said he might be back Jan 2023 (in #319) so maybe we just wait a little more.

@pahen
Copy link
Owner

pahen commented Jan 27, 2023

Hi and sorry for not responding! I've now added you both as collaborators to this repo @kamiazya @PabloLION

@pahen pahen pinned this issue Jan 27, 2023
@kamiazya
Copy link
Collaborator

@pahen Thank you very much.

I will try to focus on maintenance for a while, as per the above policy.

@pahen
Copy link
Owner

pahen commented Jan 27, 2023

@pahen Thank you very much.

I will try to focus on maintenance for a while, as per the above policy.

Thank you! 🥇

@kamiazya
Copy link
Collaborator

kamiazya commented Jan 27, 2023

@pahen I want to merge and release the first pull request you approve, is that okay?

I assume CircleCI is supposed to automatically release the package.json when the version changes, but please let me know if there is another way 🙏

(Edit)
Or let me know if there is anything you would like me to do 🙏

@pahen
Copy link
Owner

pahen commented Jan 27, 2023

The release step is done manually today. I'll add a NPM task to create a release and publish it to NPM to make it easier. PR is coming.

@PabloLION
Copy link
Collaborator Author

@kamiazya I think we should start to handling PRs now? I tried to reach you via twitter but it seems you've blocked DM from strangers. can you check my PR #319 ?

@pahen
Copy link
Owner

pahen commented Jan 27, 2023

I've added docs about creating releases now in https://github.com/pahen/madge#creating-a-release @kamiazya @PabloLION

@PabloLION
Copy link
Collaborator Author

Thanks @pahen ! Will work on it later.

@kamiazya
Copy link
Collaborator

@PabloLION DM is now open!
Also reviewed and Approved #319.

@kamiazya
Copy link
Collaborator

@pahen @PabloLION
I would start merging those with more than one Approve for Owner or Collaborator.

I will merge #342, but the release of 4.0.0, which previously raised the minimum version of Node.js, was done with a major version upgrade so I will follow that policy and release the next version at 6.0.0.

@kamiazya
Copy link
Collaborator

@pahen @PabloLION I have created a milestone to align our perceptions about the release target for v6.0.0.

Please let us know if you have any concerns!

@kamiazya
Copy link
Collaborator

Once #321 is merged, it will be ready for release.

Requested @PabloLION to review #321.

@pahen @PabloLION
Also, since release is a different topic than the issue title, why don't we move it to GitHub Discussions?

@vikingair
Copy link
Collaborator

Great job @kamiazya thanks for pushing so actively. I was also added as collaborator. Because of my newborn and new projects I will not have plenty of time, but I am willing to support this project, too 👍

@kamiazya
Copy link
Collaborator

I created this issue #347 to discuss the pros and cons of releasing v6.0.0.

@PabloLION
Copy link
Collaborator Author

Nice works @kamiazya . And GitHub Discussions seems good. Could you please activate it @pahen?

@PabloLION
Copy link
Collaborator Author

I'm now trying to label all the issues, and I feel this one can be closed already.
As we are the current collaborators, @kamiazya, please close it if you feel the same.

@PabloLION PabloLION added the dev dev-related topic of this repo label Jan 28, 2023
@kamiazya
Copy link
Collaborator

I feel that there are still some issues where the project is still in the genus.
In order to make this a sustainable community in the future, I think we need to discuss this with more people.

I want to keep this open for a while 🙏

@legobeat
Copy link
Contributor

My day job depends on madge and I have some experience with maintenance. I think it's great of @kamiazya and @PabloLION to take the lead here - just letting you know that you may @ me here if I may be of assistance to unblock anything for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev dev-related topic of this repo
Projects
None yet
Development

No branches or pull requests

5 participants