Test mongo postgres mysql tunnels and no hangs anymore :) #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
pahaz
commented
Nov 18, 2020
•
pahaz
commented
- Changed the daemon flag for all tunnel threads (is not fully backward compatible)
- Add end to end databases tests for Mongo Postgres MySQL
- Add end to end hangs tests
pahaz
commented
Nov 18, 2020
| @@ -45,7 +45,7 @@ | |||
| #: Timeout (seconds) for tunnel connection (open_channel timeout) | |||
| TUNNEL_TIMEOUT = 10.0 | |||
|
|
|||
| _DAEMON = False #: Use daemon threads in connections | |||
| _DAEMON = True #: Use daemon threads in connections | |||
pahaz
changed the title
|
Waiting for 0.3.2 release (#218). It will be at 0.4.0+ |
fernandezcuesta
approved these changes
Jan 5, 2021
| @@ -97,7 +97,7 @@ | |||
| # requirements files see: | |||
| # https://packaging.python.org/en/latest/requirements.html | |||
| install_requires=[ | |||
| 'paramiko>=1.15.2', | |||
| 'paramiko>=2.7.2', | |||
There was a problem hiding this comment.
as soon as we're just supporting python >=2.7 that's ok
| 'ed25519': paramiko.Ed25519Key} | ||
| 'ecdsa': paramiko.ECDSAKey} | ||
| if hasattr(paramiko, 'Ed25519Key'): | ||
| # NOQA: new in paramiko>=2.2: http://docs.paramiko.org/en/stable/api/keys.html#module-paramiko.ed25519key |
There was a problem hiding this comment.
dependency now is paramiko>2.7 so, is this redundant?
There was a problem hiding this comment.
yes, We will remove it in the future
| ): | ||
| key_types = (paramiko.RSAKey, paramiko.DSSKey, paramiko.ECDSAKey) | ||
| if hasattr(paramiko, 'Ed25519Key'): | ||
| # NOQA: new in paramiko>=2.2: http://docs.paramiko.org/en/stable/api/keys.html#module-paramiko.ed25519key |
There was a problem hiding this comment.
is this redundant with paramiko >2.7?
There was a problem hiding this comment.
yes, We will remove it in the future
| @@ -1605,6 +1612,14 @@ def __enter__(self): | |||
| def __exit__(self, *args): | |||
| self.stop(force=True) | |||
|
|
|||
| def __del__(self): | |||
|
@pahaz we should disable the requirement for coverage increase. It's OK to have an indicator of how much it's covered but not without that much pressure on % |
|
@fernandezcuesta yes, it's better to set it as optional ... I want to ship it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.