Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAGOPA-1351] fix #17

Merged
merged 2 commits into from
Nov 23, 2023
Merged

[PAGOPA-1351] fix #17

merged 2 commits into from
Nov 23, 2023

Conversation

cap-ang
Copy link
Contributor

@cap-ang cap-ang commented Nov 23, 2023

List of Changes

Catch and log generic exception when calling addAuthConfigurationToAPIMAuthorizer method.

Motivation and Context

When an exception occurs the function crashes and the documents following the one that caused the exception are not processed and consequently are not saved on Redis.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cap-ang cap-ang requested a review from andrea-deri November 23, 2023 15:42
@cap-ang cap-ang self-assigned this Nov 23, 2023
@cap-ang cap-ang added the bug Something isn't working label Nov 23, 2023
@cap-ang cap-ang force-pushed the PAGOPA-1351-bug-authorizer branch from e4d4348 to 72600f8 Compare November 23, 2023 17:14
Copy link

sonarcloud bot commented Nov 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Contributor

@andrea-deri andrea-deri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! 🔝

@cap-ang cap-ang merged commit ef57c01 into main Nov 23, 2023
6 of 7 checks passed
@andrea-deri andrea-deri deleted the PAGOPA-1351-bug-authorizer branch November 23, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants