[#175497433] Add Profile unsubscription on feed #86
Conversation
AleDore
requested review from
balanza,
BurnedMarshal,
francescopersico and
gunzip
as code owners
Affected stories
Generated by 🚫 dangerJS |
GetSubscriptionsFeed/handler.ts
Outdated
| // add new users to the new subscriptions, skipping those that | ||
| // unsubscribed from this service | ||
| // unsubscribed from this service or deleted its account |
There was a problem hiding this comment.
| // unsubscribed from this service or deleted its account | |
| // unsubscribed from this service or deleted their account |
GetSubscriptionsFeed/handler.ts
Outdated
| // add all users that unsubscribed from this service, skipping those | ||
| // that created the profile on the same day as the service will not | ||
| // yet know they exist | ||
| // yet know they exist or deleted its account |
There was a problem hiding this comment.
| // yet know they exist or deleted its account | |
| // yet know they exist or deleted their account |
GetSubscriptionsFeed/handler.ts
Outdated
| if (!serviceUnsubscriptionsSet.has(ps)) { | ||
| if ( | ||
| !serviceUnsubscriptionsSet.has(ps) && | ||
| !profileUnsubscriptionsSet.has(ps) |
There was a problem hiding this comment.
I think this check is useless since you either have a profile subscription OR a profile unsubscription but never both in the same day
There was a problem hiding this comment.
It is true if we mantain 7 delay days between request and effectiveness account's deletion. If we enable instant delete of personal data, it should be possible. What do you think?
There was a problem hiding this comment.
I think it's true in any scenario since when you create the (un)subscription record in the same day, you delete any previous (un)subscription here: https://github.com/pagopa/io-functions-app/blob/master/UpdateSubscriptionsFeedActivity/index.ts#L102
Ok, it seems that no tests have been written for this API. Let's integrate them! |
| const today = new Date(); | ||
| const tomorrow = new Date(today); | ||
| tomorrow.setDate(tomorrow.getDate() + 1); | ||
|
|
||
| const yesterday = new Date(today); | ||
| yesterday.setDate(yesterday.getDate() - 1); | ||
| const aServiceId = "MyServiceId" as ServiceId; | ||
|
|
||
| const yesterdayUTC = dateFmt.format(yesterday, "YYYY-MM-DD"); |
There was a problem hiding this comment.
I've noticed this: https://date-fns.org/v1.28.5/docs/startOfYesterday maybe can help
| const today = new Date(); | ||
| const tomorrow = new Date(today); | ||
| tomorrow.setDate(tomorrow.getDate() + 1); | ||
|
|
||
| const yesterday = new Date(today); | ||
| yesterday.setDate(yesterday.getDate() - 1); | ||
| const aServiceId = "MyServiceId" as ServiceId; | ||
|
|
||
| const yesterdayUTC = dateFmt.format(yesterday, "YYYY-MM-DD"); |
There was a problem hiding this comment.
I've noticed this: https://date-fns.org/v1.28.5/docs/startOfYesterday maybe can help
This PR adds retrieve for records with partitionKey
P-{date}-UonSubscriptionFeedByDaywhile serving informations about subscription feed. These kind of records are written, when users request to delete its own data and in that case, the event must be notified to subscription feed.