Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#173608840] Add email blacklist for configured services #60

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

balanza
Copy link
Contributor

@balanza balanza commented Jul 1, 2020

Added EMAIL_NOTIFICATION_SERVICE_BLACKLIST to add a list of services for which we don't send email, no matter what. The var is optional, default is: no service is blacklisted.

Usage

# blacklist service xxx
EMAIL_NOTIFICATION_SERVICE_BLACKLIST=xxx
# blacklist both services xxx and yyy
EMAIL_NOTIFICATION_SERVICE_BLACKLIST=xxx,yyy

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2020

Codecov Report

Merging #60 into master will increase coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   83.33%   83.68%   +0.35%     
==========================================
  Files           8        9       +1     
  Lines         366      374       +8     
  Branches       47       51       +4     
==========================================
+ Hits          305      313       +8     
  Misses         60       60              
  Partials        1        1              
Impacted Files Coverage Δ
CreateNotificationActivity/utils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ac3c4...c0587b9. Read the comment docs.

@balanza balanza requested a review from gunzip July 1, 2020 17:35
@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Jul 1, 2020

Affected stories

  • 🌟 #173608840: Come SERVICES voglio che poter definire una blacklist di servizi per cui ignorare l'invio mail

Generated by 🚫 dangerJS

@balanza balanza changed the title [#173608840] email balcklist [#173608840] email blacklist Jul 1, 2020
@gunzip gunzip changed the title [#173608840] email blacklist [#173608840] Add email blacklist for configured services Jul 1, 2020
@gunzip gunzip merged commit 5dce5d8 into master Jul 1, 2020
@gunzip gunzip deleted the 173608840-email-blacklist branch July 1, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants