[#169703944] check isEmailValidated / isEmailEnabled flags before sending email #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=======================================
Coverage 83.97% 83.97%
=======================================
Files 6 6
Lines 337 337
Branches 43 43
=======================================
Hits 283 283
Misses 53 53
Partials 1 1 Continue to review full report at Codecov.
|
gunzip
commented
Mar 8, 2020
| @@ -154,8 +154,12 @@ export const getCreateNotificationActivityHandler = ( | |||
|
|
|||
| // whether email notifications are enabled in this user profile - this is | |||
| // true by default, it's false only for users that have isEmailEnabled = false | |||
| // in their profile | |||
| const isEmailEnabledInProfile = profile.isEmailEnabled; | |||
| // in their profile | ||
| const isEmailEnabledInProfile = profile.isEmailEnabled; | ||
| // in their profile. We assume it's true when not defined in user's profile. | ||
| const isEmailEnabledInProfile = profile.isEmailEnabled !== false; |
gunzip
changed the title
Undermaken
reviewed
Mar 8, 2020
|
|
||
| // Check if the email in the user profile is validated. | ||
| // we assume it's true when not defined in user's profile. | ||
| const isEmailValidatedInProfile = profile.isEmailValidated !== false; |
There was a problem hiding this comment.
@gunzip Could you confirm the field isEmailValidated is set to false on CIE first authentication?
Because this assumption is valid only for SPID users
There was a problem hiding this comment.
There was a problem hiding this comment.
this fix regards existing (SPID) users that never had this field set up (so it's undefined in their profile)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since not every user profile stored into CosmosDB has email flags defined (so they are neither true nor false), we use strict equality and assume
isEmailEnabled = trueandisEmailValidated = truewhen they're undefined.