-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#IP-292] Add override on isEmailEnabled value for old profiles #137
[#IP-292] Add override on isEmailEnabled value for old profiles #137
Conversation
Example of PR titles that include pivotal stories:
New dependencies added: date-fnsAuthor: Unknown Description: Modern JavaScript date utility library Homepage: https://github.com/date-fns/date-fns#readme
|
taskEither.of( | ||
some({ | ||
...aRetrievedProfile, | ||
blockedInboxOrChannels: { agid: BlockedInboxOrChannelEnum.INBOX } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use anonymous service ID, and i think that the value should be an array
blockedInboxOrChannels: { agid: BlockedInboxOrChannelEnum.INBOX } | |
blockedInboxOrChannels: { myServiceId: [BlockedInboxOrChannelEnum.INBOX] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
List of Changes
EMAIL_MODE_SWITCH_LIMIT_DATE
env propertyStoreMessageContentActivity
in order to overrideisEmailEnabled
based on profile' s timestamp checkio-functions-commons
versionStoreMessageContentActivity
io-functions-commons
upgradeMotivation and Context
We want that an organization can't reach on email channel a citizen with an old profile, or even if his profile has not been recently upserted (after
EMAIL_MODE_SWITCH_LIMIT_DATE
)How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: