[#ENTE-82] Limit API access for incomplete services #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example of PR titles that include pivotal stories:
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
==========================================
+ Coverage 81.82% 83.42% +1.59%
==========================================
Files 27 27
Lines 886 899 +13
Branches 89 92 +3
==========================================
+ Hits 725 750 +25
+ Misses 160 148 -12
Partials 1 1
Continue to review full report at Codecov.
|
BurnedMarshal
requested review from
AleDore,
balanza and
francescopersico
as code owners
BurnedMarshal
force-pushed
the
ENTE-82-disable-api-incomplete-services
branch
from
4708aa6 to
b687701
Compare
AleDore
reviewed
May 6, 2021
CreateMessage/handler.ts
Outdated
Comment on lines
434
to
437
| .map(_1 => true) | ||
| .mapLeft( | ||
| _1 => ResponseErrorForbiddenNotAuthorizedForRecipient | ||
| ) |
There was a problem hiding this comment.
Suggested change
| .map(_1 => true) | |
| .mapLeft( | |
| _1 => ResponseErrorForbiddenNotAuthorizedForRecipient | |
| ) | |
| .bimap( | |
| ResponseErrorForbiddenNotAuthorizedForRecipient, | |
| _1 => true | |
| ) |
There was a problem hiding this comment.
Fixed in af84ae2
| userAttributes.service.authorizedRecipients, | ||
| fiscalCode | ||
| ) | ||
| ).mapLeft(_ => ResponseErrorForbiddenNotAuthorizedForRecipient) |
There was a problem hiding this comment.
Suggested change
| ).mapLeft(_ => ResponseErrorForbiddenNotAuthorizedForRecipient) | |
| ).mapLeft(ResponseErrorForbiddenNotAuthorizedForRecipient) |
There was a problem hiding this comment.
mapLeft need a function and ResponseErrorForbiddenNotAuthorizedForRecipient is not
utils/profile.ts
Outdated
Comment on lines
126
to
127
| .map(_1 => true) | ||
| .mapLeft(_1 => ResponseErrorForbiddenNotAuthorizedForRecipient) |
There was a problem hiding this comment.
Suggested change
| .map(_1 => true) | |
| .mapLeft(_1 => ResponseErrorForbiddenNotAuthorizedForRecipient) | |
| .bimap(ResponseErrorForbiddenNotAuthorizedForRecipient, | |
| _1 => true | |
| ) |
There was a problem hiding this comment.
Fixed in af84ae2
AleDore
approved these changes
May 10, 2021
BurnedMarshal
force-pushed
the
ENTE-82-disable-api-incomplete-services
branch
from
af84ae2 to
516710d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
If the feature flag
FF_DISABLE_INCOMPLETE_SERVICESistrueonly services matching thatValidServicetype can use:Some Services added into
FF_INCOMPLETE_SERVICE_WHITELISTcan bypassValidServicecheck.Motivation and Context
A Services that haven't the required metadata information can't be enabled to use some API. We need to specify through the feature flag when this filtering is enabled and a whitelist of services that don't need this check.
How Has This Been Tested?
unit test
test with
io-mockScreenshots (if appropriate):
Types of changes
Checklist: