Skip to content

Commit

Permalink
Log email/webhook delivery errors in application insights exceptions
Browse files Browse the repository at this point in the history
  • Loading branch information
cloudify committed Jun 28, 2020
1 parent 31b3eda commit 3021408
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion EmailNotificationActivity/handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ export const getEmailNotificationActivityHandler = (
const error = sendResult.value;
// track the event of failed delivery
context.log.error(`${logPrefix}|ERROR=${error.message}`);
throw new Error("Error while sending email");
throw new Error(`Error while sending email: ${error.message}`);
}

context.log.verbose(`${logPrefix}|RESULT=SUCCESS`);
Expand Down
2 changes: 1 addition & 1 deletion WebhookNotificationActivity/handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ export const getWebhookNotificationActivityHandler = (
const error = sendResult.value;
context.log.error(`${logPrefix}|ERROR=${error.message}`);
if (isTransientError(error)) {
throw new Error("Error while calling webhook");
throw new Error(`Error while calling webhook: ${error.message}`);
} else {
return WebhookNotificationActivityResult.encode({
kind: "FAILURE",
Expand Down

0 comments on commit 3021408

Please sign in to comment.