-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CDC): [IOBP-1010] Remove CDC Bonus files and related functions #6630
Conversation
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOBP-1010 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6630 +/- ##
===========================================
+ Coverage 39.15% 49.53% +10.38%
===========================================
Files 1558 1546 -12
Lines 32361 32146 -215
Branches 7291 7278 -13
===========================================
+ Hits 12671 15925 +3254
+ Misses 19657 16171 -3486
- Partials 33 50 +17
... and 303 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's awesome! 🧹
What do you think also removing every definitions reference even inside the generate-api-models.sh
file and removing the assets/CdcSwagger.yml
file?
🧹 here 8d131bb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Short description
This pull request involves the removal of several components and related functionalities for the CDC bonus feature. The most important changes include the deletion of tracking logic, API client code, UI components, and associated tests.
List of changes proposed in this pull request
cdc
folderHow to test
Ensure the application is not crashing