Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CDC): [IOBP-1010] Remove CDC Bonus files and related functions #6630

Merged
merged 10 commits into from
Jan 24, 2025

Conversation

LeleDallas
Copy link
Contributor

Short description

This pull request involves the removal of several components and related functionalities for the CDC bonus feature. The most important changes include the deletion of tracking logic, API client code, UI components, and associated tests.

List of changes proposed in this pull request

  • Removed CDC Bonus files inside cdc folder
  • Removed CDC Bonus saga, store, navigation and analytics

How to test

Ensure the application is not crashing

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOBP-1010

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.53%. Comparing base (0aed07e) to head (13ea93b).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6630       +/-   ##
===========================================
+ Coverage   39.15%   49.53%   +10.38%     
===========================================
  Files        1558     1546       -12     
  Lines       32361    32146      -215     
  Branches     7291     7278       -13     
===========================================
+ Hits        12671    15925     +3254     
+ Misses      19657    16171     -3486     
- Partials       33       50       +17     
Files with missing lines Coverage Δ
ts/features/bonus/common/store/reducers/index.ts 100.00% <ø> (ø)
ts/navigation/AuthenticatedStackNavigator.tsx 17.64% <ø> (+2.64%) ⬆️
ts/navigation/params/AppParamsList.ts 100.00% <ø> (+25.00%) ⬆️
ts/sagas/startup.ts 34.83% <ø> (+0.38%) ⬆️

... and 303 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aed07e...13ea93b. Read the comment docs.

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome! 🧹

What do you think also removing every definitions reference even inside the generate-api-models.sh file and removing the assets/CdcSwagger.yml file?

@LeleDallas
Copy link
Contributor Author

What do you think about removing the RadioButtonList component? It's a legacy component that is only used in the CDC flow.

🧹 here 8d131bb

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants