Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IT Wallet): [SIW-1975] Request app review after first viewing of driving license detail screen #6623

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

RiccardoMolinari95
Copy link
Collaborator

@RiccardoMolinari95 RiccardoMolinari95 commented Jan 21, 2025

Short description

This PR adds the ability to request a review on the app store when the driving license detail screen is viewed for the first time and the user returns to the wallet section.

List of changes proposed in this pull request

  • Added a new action itwReviewRequested in the preferences actions store of itw
  • Added a new state reviewRequested to feature.itw.preferences
  • Added a selector itwReviewRequestedSelector to retrieve the reviewRequested state
  • Created a hook useItwReviewRequest to monitor the reviewRequested state and request an app review if needed
  • Updated ItwWalletCardsContainer to use the new hook

How to test

Verify that the app review request appears only when the driving license detail is viewed for the first time and is not triggered for other credentials.

Test Case Scenario:

  1. Create ITWallet
  2. Add the European Health Insurance Card credential to the wallet.
  3. Add the Driving License credential to the wallet.
  4. Open the detail screen of the European Health Insurance Card credential -> Expected Result: No review request is displayed.
  5. Open the detail screen of the Driving License credential -> Expected Result: The review request is displayed.
  6. Open the detail screen of the Driving License credential again -> Expected Result: No review request is displayed.
Screen.Recording.2025-01-22.at.12.59.25.mov

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue SIW-1975

Copy link
Contributor

github-actions bot commented Jan 21, 2025

PR Title Validation for conventional commit type

✅ All good! PR title follows conventional commit type.

@RiccardoMolinari95 RiccardoMolinari95 marked this pull request as draft January 21, 2025 17:40
@RiccardoMolinari95 RiccardoMolinari95 changed the title [SIW-1975] Request app review after first viewing of driving license detail screen [SIW-1975] Request app review after first viewing of driving license detail screen Jan 21, 2025
@RiccardoMolinari95 RiccardoMolinari95 changed the title [SIW-1975] Request app review after first viewing of driving license detail screen chore(IT Wallet): [SIW-1975] Request app review after first viewing of driving license detail screen Jan 21, 2025
@RiccardoMolinari95 RiccardoMolinari95 changed the title chore(IT Wallet): [SIW-1975] Request app review after first viewing of driving license detail screen chore(IT Wallet): [SIW-1975] Request app review Jan 21, 2025
@RiccardoMolinari95 RiccardoMolinari95 changed the title chore(IT Wallet): [SIW-1975] Request app review chore(IT Wallet): [SIW-1975] Request app review after first viewing of driving license detail screen Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 54.54545% with 10 lines in your changes missing coverage. Please review.

Project coverage is 49.55%. Comparing base (08fbb60) to head (a4204c2).

Files with missing lines Patch % Lines
.../screens/ItwPresentationCredentialDetailScreen.tsx 0.00% 8 Missing ⚠️
...ures/itwallet/common/store/reducers/preferences.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6623   +/-   ##
=======================================
  Coverage   49.54%   49.55%           
=======================================
  Files        1546     1547    +1     
  Lines       32149    32171   +22     
  Branches     7234     7234           
=======================================
+ Hits        15928    15941   +13     
- Misses      16183    16192    +9     
  Partials       38       38           
Files with missing lines Coverage Δ
...twallet/common/hooks/useItwPendingReviewRequest.ts 100.00% <100.00%> (ø)
...tures/itwallet/common/store/actions/preferences.ts 100.00% <100.00%> (ø)
...res/itwallet/common/store/selectors/preferences.ts 100.00% <100.00%> (ø)
...llet/wallet/components/ItwWalletCardsContainer.tsx 100.00% <100.00%> (ø)
...ures/itwallet/common/store/reducers/preferences.ts 86.36% <0.00%> (-8.64%) ⬇️
.../screens/ItwPresentationCredentialDetailScreen.tsx 7.50% <0.00%> (-1.88%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08fbb60...a4204c2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants