-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [IOPID-2615] Add specific action to clear the session state #6615
base: master
Are you sure you want to change the base?
Conversation
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOPID-2615 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6615 +/- ##
=======================================
Coverage 49.93% 49.93%
=======================================
Files 1567 1567
Lines 32462 32465 +3
Branches 7310 7312 +2
=======================================
+ Hits 16210 16212 +2
- Misses 16213 16215 +2
+ Partials 39 38 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just a note: you could also add the ‘legal-review-needed’ label to make it clearer why there is the label ‘dont merge’. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! 🚀
Short description
This PR introduces a new action to clear the session state during the first app installation. This resolves the issue of session information persisting across multiple app installations on the same iOS device.
The app now behaves correctly because a lollipop check triggers a
sessionInvalid
action if the check fails.Demo 🎦
Before.mov
After.mov
clear-current-sessoin-mp.mov
List of changes proposed in this pull request
clearCurrentSession
action.clearCurrentSession
action is dispatched during the first app installation to remove any residual session state from a previous installation.How to test
LandingPage
without asessionInvalid
action being dispatched.