-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOCOM-1823,IOCOM-1826] FIMS history get saga and header component tests #6593
Merged
forrest57
merged 9 commits into
master
from
IOCOM-1823-IOCOM-1826_FIMS_history_saga_and_header_tests
Jan 13, 2025
Merged
[IOCOM-1823,IOCOM-1826] FIMS history get saga and header component tests #6593
forrest57
merged 9 commits into
master
from
IOCOM-1823-IOCOM-1826_FIMS_history_saga_and_header_tests
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1826_FIMS_history_saga_and_header_tests
forrest57
requested review from
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
January 9, 2025 15:28
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Vangaorth
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
forrest57
deleted the
IOCOM-1823-IOCOM-1826_FIMS_history_saga_and_header_tests
branch
January 13, 2025 17:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
addition of said unit tests
List of changes proposed in this pull request
handleGetFimsHistorySaga
FimsHIstoryHeaderComponent
, with its own snapshotHow to test
all tests should pass