chore(IT Wallet): [SIW-1949] Display email address in the same line in issuance failure screen #6589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gispada
requested review from
ChrisMattew,
freddi301 and
a team
as code owners
Jira Pull Request LinkThis Pull Request refers to the following Jira issue SIW-1949 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6589 +/- ##
=======================================
Coverage 49.28% 49.28%
=======================================
Files 1558 1558
Lines 32156 32156
Branches 7325 7326 +1
=======================================
Hits 15849 15849
Misses 16258 16258
Partials 49 49
Continue to review full report in Codecov by Sentry.
|
mastro993
approved these changes
Jan 8, 2025
LazyAfternoons
pushed a commit
that referenced
this pull request
Jan 9, 2025
…n issuance failure screen (#6589) ## Short description This PR changes the line break strategy in the issuance failure screens to display email addresses in the same line. The issue seems to affect Android devices only. ## List of changes proposed in this pull request - Added `textBreakStrategy: "simple"` in `ItwIssuanceEidFailureScreen` and `ItwIssuanceCredentialFailureScreen` ## How to test The easiest way to test it is to mock an error during credential issuance with a message that contains an email address. |Before|After| |------|-----| |<img src="https://github.com/user-attachments/assets/fe546b8e-249a-4955-921f-39106dfa1242" width="240"/>|<img src="https://github.com/user-attachments/assets/ad478750-93a5-4b5c-8024-2d166c4be92d" width="240"/>|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR changes the line break strategy in the issuance failure screens to display email addresses in the same line. The issue seems to affect Android devices only.
List of changes proposed in this pull request
textBreakStrategy: "simple"inItwIssuanceEidFailureScreenandItwIssuanceCredentialFailureScreenHow to test
The easiest way to test it is to mock an error during credential issuance with a message that contains an email address.