-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [IOBP-1115] Replace deprecated components and functions for IDPay #6586
Merged
LeleDallas
merged 35 commits into
master
from
IOBP-1115-upgrade-deprecated-components-for-idpay
Jan 16, 2025
Merged
refactor: [IOBP-1115] Replace deprecated components and functions for IDPay #6586
LeleDallas
merged 35 commits into
master
from
IOBP-1115-upgrade-deprecated-components-for-idpay
Jan 16, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace TopScreenComponent with useHeaderSecondLevel
replace BaseScreenComponent with useHeaderSecondLevel
Replace RNavScreenWithLargeHeader with IOScrollViewWithLargeHeader
replace Layout with LinearTransition
replace GradientScrollView with IOScrollView
LeleDallas
requested review from
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
January 7, 2025 12:36
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOBP-1115 |
Replace IOScrollView with IOScrollViewWithLargeHeader as it provides more props for rendering purpose
Hantex9
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a huge rework, really well done 🚀
LGTM! 🟢
LeleDallas
deleted the
IOBP-1115-upgrade-deprecated-components-for-idpay
branch
January 16, 2025 16:20
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
…em components (#6597) ## Short description > [!WARNING] > This PR depends on #6586 This pull request focuses on enhancing the integration of the design system list components for IDPay screens currently utilizing custom tables and lists ## List of changes proposed in this pull request - Apply `ListItem` to IDPay timeline screens - Apply `ListItem` to IDPay initiative screens - Delete unused custom `Table` component moving its type in main file ## How to test Ensure that all replaced components are properly aligned with design standards ## Preview https://github.com/user-attachments/assets/f5da985d-9c37-43ef-b80f-558645997f5c --------- Co-authored-by: Alessandro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR is replacing legacy components for IDPay screens to align them with design standards
Warning
This PR depends on #6584
List of changes proposed in this pull request
FooterActions
from design systemRNavScreenWithLargeHeader
withIOScrollViewWithLargeHeader
GradientScrollView
withIOScrollViewWithLargeHeader
(thanks @dmnplb)jest
deprecated functions (toBeCalledWith
,toBeCalledTimes
andtoBeCalled
)Layout
ofreact-native-reanimated
withLinearTransition
back
button in onboarding screens withIOScrollViewWithLargeHeader
IOScrollViewWithLargeHeader
How to test
Ensure that all legacy components are replaced and properly aligned with standards
Preview
Screen.Recording.2025-01-08.at.17.49.58.mov
Screen.Recording.2025-01-08.at.17.13.07.mov
Screen.Recording.2025-01-08.at.17.44.15.mov
Screen.Recording.2025-01-08.at.17.13.44.mov
Screen.Recording.2025-01-08.at.17.53.58.mov
Screen.Recording.2025-01-08.at.17.28.48.mov
Screen.Recording.2025-01-08.at.17.52.13.mov
Screen.Recording.2025-01-08.at.17.29.27.mov