-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [IOBP-1096] Replace legacy markdown component for IDPay #6585
Conversation
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOBP-1096 |
Is not this a duplicate of #6445? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6585 +/- ##
==========================================
+ Coverage 49.34% 49.36% +0.01%
==========================================
Files 1566 1566
Lines 32287 32274 -13
Branches 7288 7336 +48
==========================================
- Hits 15932 15931 -1
+ Misses 16316 16293 -23
- Partials 39 50 +11
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Yes, it's similar, but this one is listed in the B&P board as a refactor task for the IDPay screen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Short description
This pull request includes several changes to the
idpay
feature components, focusing on replacing theLegacyMarkdown
component with the newIOMarkdown
component.List of changes proposed in this pull request
LegacyMarkdown
withIOMarkdown
for displaying markdown contentOnboardingDescriptionMarkdown
component ints/features/idpay/onboarding/components/OnboardingDescriptionMarkdown.tsx
as already done in chore(Cross):[IOAPPX-422] Replace the legacy markdown renderer with IOMarkdown #6445How to test
Ensure that all legacy IDPay markdown components are aligned with the established design requirements