refactor: [IOBP-1091] Paid in app empty state screen #6575
Conversation
LeleDallas
requested review from
thisisjp,
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOBP-1091 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6575 +/- ##
==========================================
- Coverage 49.29% 49.29% -0.01%
==========================================
Files 1555 1555
Lines 32119 32122 +3
Branches 7312 7268 -44
==========================================
Hits 15834 15834
- Misses 16236 16250 +14
+ Partials 49 38 -11
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| const emptyProps: { | ||
| title: string; | ||
| subtitle?: string; | ||
| pictogram: IOPictograms; | ||
| } = |
There was a problem hiding this comment.
I noticed you’ve defined a custom type for emptyProps. Since these properties are closely tied to OperationResultScreenContent, I suggest creating a derived type using Pick. This will make the code more maintainable and consistent with the component’s actual props. Example:
type OperationResultEmptyProps = Pick<
typeof OperationResultScreenContent.propTypes,
"title" | "subtitle" | "pictogram"
>;This also helps avoid duplicating definitions if the props change in the future. Let me know what do you think about.
There was a problem hiding this comment.
What do you think to use OperationResultScreenContentProps type instead of typeof OperationResultScreenContent.propTypes?
There was a problem hiding this comment.
Yes, it makes more sense. I saw that the type OperationResultScreenContentProps was not exported. So in this case it's better to export it and use it 👍
There was a problem hiding this comment.
You can find it here d9cbd7f
| type OperationResultEmptyProps = Pick< | ||
| OperationResultScreenContentProps, | ||
| "title" | "subtitle" | "pictogram" | ||
| >; |
There was a problem hiding this comment.
Could you declare the type definition outside the component hook?
Short description
This pull request includes updates to localization files and enhancements to the
ReceiptListScreencomponent. The most important changes is refactoring the empty state logic in the receipt list screen.List of changes proposed in this pull request
emptyPropsobject based on thenoticeCategory.emptyPayerlocale for displaying payment receipts made in the app.How to test
Pagamentitap onVedi tuttePagate in apptab is display correct empty statePreview
Screen.Recording.2024-12-20.at.10.06.52.mov