chore(IT Wallet): [SIW-1639] Show error banner when wallet instance status check fails #6568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira Pull Request LinkThis Pull Request refers to the following Jira issue SIW-1639 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6568 +/- ##
==========================================
- Coverage 49.28% 49.28% -0.01%
==========================================
Files 1558 1559 +1
Lines 32156 32179 +23
Branches 7325 7332 +7
==========================================
+ Hits 15849 15860 +11
- Misses 16258 16269 +11
- Partials 49 50 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
LazyAfternoons
pushed a commit
that referenced
this pull request
Jan 9, 2025
…tatus check fails (#6568) ## Short description This PR handles unexpected failures during the request to fetch the Wallet Instance status. When it is not possible to determine the status, the Wallet will not be available. ## List of changes proposed in this pull request - Created `ItwWalletNotAvailableBanner` component - Turned `itWallet.walletInstance.status` into a pot for better async handling (+ store migration) - Hide `ItwWalletReadyBanner` and `ItwWalletCardsContainer` when the Wallet Instance status call failed ## How to test - Get a wallet instance, then fake an error in `api/v1/wallet/wallet-instances/<wallet_instance_id>/status`: you should see the following screen Regression tests: - Get a wallet instance and restart the app: everything should work as before - Get a wallet instance, then revoke it: everything should work as before (with an alert only shown once) <img src="https://github.com/user-attachments/assets/cf8d36d0-0fad-4e5e-a4a8-80b75ce3c72b" width="240" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR handles unexpected failures during the request to fetch the Wallet Instance status. When it is not possible to determine the status, the Wallet will not be available.
List of changes proposed in this pull request
ItwWalletNotAvailableBannercomponentitWallet.walletInstance.statusinto a pot for better async handling (+ store migration)ItwWalletReadyBannerandItwWalletCardsContainerwhen the Wallet Instance status call failedHow to test
api/v1/wallet/wallet-instances/<wallet_instance_id>/status: you should see the following screenRegression tests: