Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IT Wallet): [SIW-1933] Handle Trustmark QR code generation failures #6558

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

mastro993
Copy link
Contributor

Short description

Include a summary of the changes.

List of changes proposed in this pull request

  • Feature A
  • Feature B

How to test

Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

@mastro993 mastro993 self-assigned this Dec 17, 2024
@pagopa-github-bot pagopa-github-bot changed the title [SIW-1933] Handle Trustmark QR code generation failures chore(IT Wallet): [SIW-1933] Handle Trustmark QR code generation failures Dec 17, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 17, 2024

Affected stories

  • ⚙️ SIW-1933: [io-app] Gestire errori generazione QR Code trustmark

Generated by 🚫 dangerJS against dcc41ad

Copy link
Contributor

github-actions bot commented Dec 17, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue SIW-1933

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 17.77778% with 37 lines in your changes missing coverage. Please review.

Project coverage is 41.43%. Comparing base (9321272) to head (b6eac9a).

Files with missing lines Patch % Lines
...wallet/trustmark/components/ItwTrustmarkQrCode.tsx 15.38% 11 Missing ⚠️
...ustmark/components/ItwTrustmarkExpirationTimer.tsx 9.09% 10 Missing ⚠️
ts/features/itwallet/trustmark/machine/failure.ts 25.00% 6 Missing ⚠️
ts/features/itwallet/trustmark/machine/actions.ts 0.00% 4 Missing ⚠️
ts/store/reducers/debug.ts 25.00% 3 Missing ⚠️
ts/features/itwallet/trustmark/machine/actors.ts 0.00% 1 Missing ⚠️
ts/features/itwallet/trustmark/machine/machine.ts 0.00% 1 Missing ⚠️
...s/features/itwallet/trustmark/machine/provider.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6558      +/-   ##
==========================================
- Coverage   49.29%   41.43%   -7.87%     
==========================================
  Files        1555     1540      -15     
  Lines       32119    31748     -371     
  Branches     7312     7214      -98     
==========================================
- Hits        15834    13154    -2680     
- Misses      16236    18551    +2315     
+ Partials       49       43       -6     
Files with missing lines Coverage Δ
ts/components/QrCodeImage.tsx 80.00% <100.00%> (ø)
...et/trustmark/components/ItwCredentialTrustmark.tsx 20.96% <ø> (ø)
...s/features/itwallet/trustmark/machine/selectors.ts 60.00% <100.00%> (+10.00%) ⬆️
...trustmark/screens/ItwCredentialTrustmarkScreen.tsx 25.00% <ø> (-1.67%) ⬇️
ts/features/itwallet/trustmark/machine/actors.ts 6.25% <0.00%> (ø)
ts/features/itwallet/trustmark/machine/machine.ts 15.38% <0.00%> (-59.62%) ⬇️
...s/features/itwallet/trustmark/machine/provider.tsx 25.00% <0.00%> (-3.58%) ⬇️
ts/store/reducers/debug.ts 52.38% <25.00%> (-19.85%) ⬇️
ts/features/itwallet/trustmark/machine/actions.ts 10.00% <0.00%> (-2.50%) ⬇️
ts/features/itwallet/trustmark/machine/failure.ts 25.00% <25.00%> (ø)
... and 2 more

... and 237 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9321272...b6eac9a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants