Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOPID-2296] Add state to track successful login event #6298

Merged
merged 12 commits into from
Oct 29, 2024

Conversation

shadowsheep1
Copy link
Member

@shadowsheep1 shadowsheep1 commented Oct 17, 2024

Short description

This PR introduces a new Redux state, userFromSuccessLogin, to track when a successful login has occurred.

Note

A future PR will refactor and group all login-related features under a single folder inside the features directory to better organize the codebase.

List of changes proposed in this pull request

  • Added a new userFromSuccessLogin field to the Redux store to indicate when a login has been successfully completed.
  • The initial value of userFromSuccessLogin is set to false on app start.
  • Upon a successful login, the userFromSuccessLogin value is updated to true.

How to test

  1. Start the application and inspect the Redux state to verify that userFromSuccessLogin is initialized to false.
  2. Perform a login and verify that the userFromSuccessLogin state is updated to true upon successful authentication.

@shadowsheep1
Copy link
Member Author

shadowsheep1 commented Oct 17, 2024

@forrest57 have a look if that'd be good for you!

@shadowsheep1 shadowsheep1 marked this pull request as ready for review October 17, 2024 14:21
@shadowsheep1 shadowsheep1 requested a review from a team as a code owner October 17, 2024 14:21
@pagopa-github-bot pagopa-github-bot changed the title [IOPID-2296] Add state to track successful login event feat: [IOPID-2296] Add state to track successful login event Oct 17, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 17, 2024

Affected stories

  • 🌟 IOPID-2296: [APP] Sviluppo informazione "Arrivo dopo la Login"
    subtask of

Generated by 🚫 dangerJS against 54f257d

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.07%. Comparing base (4f204b4) to head (54f257d).
Report is 646 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6298      +/-   ##
==========================================
- Coverage   48.42%   47.07%   -1.35%     
==========================================
  Files        1488     1809     +321     
  Lines       31617    36789    +5172     
  Branches     7669     8863    +1194     
==========================================
+ Hits        15311    17320    +2009     
- Misses      16238    19404    +3166     
+ Partials       68       65       -3     
Files with missing lines Coverage Δ
ts/features/common/store/reducers/index.ts 100.00% <ø> (ø)
ts/features/login/info/store/reducers/index.ts 100.00% <100.00%> (ø)

... and 1430 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e4ba5c...54f257d. Read the comment docs.

Copy link
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me LGTM, however I am waiting for @forrest57 's approval to merge 🚀

@Ladirico Ladirico merged commit be5b90b into master Oct 29, 2024
13 checks passed
@Ladirico Ladirico deleted the IOPID-2296-I-came-from-login branch October 29, 2024 08:38
@Vangaorth
Copy link
Contributor

With this comment I just want to track the fact that the PR was (is) also good for the IO-COM team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants