-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IOPID-2296] Add state to track successful login event #6298
Conversation
@forrest57 have a look if that'd be good for you! |
Affected stories
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6298 +/- ##
==========================================
- Coverage 48.42% 47.07% -1.35%
==========================================
Files 1488 1809 +321
Lines 31617 36789 +5172
Branches 7669 8863 +1194
==========================================
+ Hits 15311 17320 +2009
- Misses 16238 19404 +3166
+ Partials 68 65 -3
... and 1430 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me LGTM, however I am waiting for @forrest57 's approval to merge 🚀
With this comment I just want to track the fact that the PR was (is) also good for the IO-COM team |
Short description
This PR introduces a new Redux state,
userFromSuccessLogin
, to track when a successful login has occurred.Note
A future PR will refactor and group all login-related features under a single folder inside the
features
directory to better organize the codebase.List of changes proposed in this pull request
userFromSuccessLogin
field to the Redux store to indicate when a login has been successfully completed.userFromSuccessLogin
is set tofalse
on app start.userFromSuccessLogin
value is updated totrue
.How to test
userFromSuccessLogin
is initialized tofalse
.userFromSuccessLogin
state is updated to true upon successful authentication.