Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Bonus Pagamenti Digitali): [#177357472] Wrong decode during the add of a new privative card to the wallet #2902

Merged
merged 4 commits into from
Mar 16, 2021

Conversation

fabriziofff
Copy link
Contributor

@fabriziofff fabriziofff commented Mar 16, 2021

Short description

This pr fixes the wrong decode of the /cobadge/add-wallets response when adding a new PrivativePaymentMethod.

List of changes proposed in this pull request

  • Changed addCobadgeToWallet in order to return a RawPaymentMethod instead of RawCreditCardPaymentMethod
  • Changed handleAddCoBadgeToWallet in order to check the CreditCardPaymentMethod type
  • Changed handleAddPrivativeToWallet in order to check the RawPrivativePaymentMethod type
  • Changed the type for addPrivativeToWallet, addedPrivativeReducer, onboardingPrivativeAddedSelector, onboardingPrivativeAddingResultSelector

@pagopa-github-bot pagopa-github-bot changed the title [#177357472] Wrong decode during the add of a new privative card to the wallet fix(Bonus Pagamenti Digitali): [#177357472] Wrong decode during the add of a new privative card to the wallet Mar 16, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Mar 16, 2021

Affected stories

  • 🐞 #177357472: Le carte privative aggiunte al wallet vengono decodificate come carte di credito

Generated by 🚫 dangerJS against 908755f

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #2902 (908755f) into master (97ffd56) will decrease coverage by 0.00%.
The diff coverage is 42.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2902      +/-   ##
==========================================
- Coverage   58.06%   58.06%   -0.01%     
==========================================
  Files         882      882              
  Lines       24201    24213      +12     
  Branches     4461     4465       +4     
==========================================
+ Hits        14053    14059       +6     
- Misses      10057    10063       +6     
  Partials       91       91              
Impacted Files Coverage Δ
...ding/cobadge/saga/networking/addCobadgeToWallet.ts 41.17% <0.00%> (-3.27%) ⬇️
...wallet/onboarding/privative/store/actions/index.ts 100.00% <ø> (ø)
...arding/privative/store/reducers/addingPrivative.ts 60.00% <ø> (ø)
...allet/onboarding/privative/store/reducers/index.ts 100.00% <ø> (ø)
ts/utils/paymentMethod.ts 78.40% <0.00%> (ø)
...wallet/onboarding/cobadge/saga/networking/index.ts 62.96% <44.44%> (-3.71%) ⬇️
...tive/saga/networking/handleAddPrivativeToWallet.ts 57.14% <44.44%> (ø)
...oarding/privative/store/reducers/addedPrivative.ts 61.90% <60.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ffd56...908755f. Read the comment docs.

@fabriziofff fabriziofff marked this pull request as ready for review March 16, 2021 10:57
@Undermaken Undermaken merged commit 0ac7d0c into master Mar 16, 2021
@Undermaken Undermaken deleted the 177357472-wrong-decode-add-privative-to-wallet branch March 16, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants