Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Bonus Pagamenti Digitali): [#176993827] In SuperCashbackRanking bottom sheet text is selectable #2866

Merged
merged 2 commits into from
Mar 4, 2021

Conversation

Undermaken
Copy link
Contributor

Short description

This PR fixes an annoying behavior that allows text selection in bottom sheet making a bad UX

@pagopa-github-bot pagopa-github-bot changed the title [#176993827] In SuperCashbackRanking bottom sheet text is selectable fix(Bonus Pagamenti Digitali): [#176993827] In SuperCashbackRanking bottom sheet text is selectable Mar 4, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Mar 4, 2021

Affected stories

  • 🐞 #176993827: [trivial] Il testo della BS è selezionabile su Android

Generated by 🚫 dangerJS against ac5ef52

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #2866 (ac5ef52) into master (37b7e7b) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2866   +/-   ##
=======================================
  Coverage   57.37%   57.37%           
=======================================
  Files         835      835           
  Lines       23120    23120           
  Branches     4342     4342           
=======================================
  Hits        13264    13264           
  Misses       9768     9768           
  Partials       88       88           
Impacted Files Coverage Δ
ts/components/ui/Markdown/index.tsx 54.71% <ø> (ø)
...ents/superCashbackRanking/SuperCashbackRanking.tsx 65.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37b7e7b...ac5ef52. Read the comment docs.

@Undermaken Undermaken marked this pull request as ready for review March 4, 2021 08:23
@fabriziofff fabriziofff merged commit faf26fe into master Mar 4, 2021
@fabriziofff fabriziofff deleted the 176993827-avoid-bs-text-selection branch March 4, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants