Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#177187748] Unlock the search for SIA and ICCREA (for test only) #2862

Merged
merged 4 commits into from
Mar 3, 2021

Conversation

fabriziofff
Copy link
Contributor

@fabriziofff fabriziofff commented Mar 3, 2021

Short description

This pr allows to test the co-badge search for SIA and ICCREA services. Will be reverted after the release of the internal version.

List of changes proposed in this pull request

  • Enable BPD Test Overlay
  • Remove CoBadgeStartKoDisabled rendering path.

@pagopa-github-bot pagopa-github-bot changed the title [#177187748] Unlock the search for SIA and ICCREA (for test only) feat(Bonus Pagamenti Digitali): [#177187748] Unlock the search for SIA and ICCREA (for test only) Mar 3, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Mar 3, 2021

Affected stories

  • 🌟 #177187748: Come TESTER voglio poter cercare una carta co-badge per le banche appartenenti ai centri servizio ICCREA o SIA

Generated by 🚫 dangerJS against bb5312e

@fabriziofff fabriziofff marked this pull request as ready for review March 3, 2021 16:48
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #2862 (bb5312e) into master (862dfd9) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2862      +/-   ##
==========================================
- Coverage   57.37%   57.31%   -0.06%     
==========================================
  Files         835      834       -1     
  Lines       23120    23083      -37     
  Branches     4342     4342              
==========================================
- Hits        13264    13231      -33     
+ Misses       9768     9764       -4     
  Partials       88       88              
Impacted Files Coverage Δ
...rding/cobadge/screens/start/CoBadgeStartScreen.tsx 100.00% <100.00%> (ø)
...obadge/screens/start/ko/CoBadgeStartKoDisabled.tsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 862dfd9...bb5312e. Read the comment docs.

@Undermaken Undermaken merged commit 8f29540 into master Mar 3, 2021
fabriziofff added a commit that referenced this pull request Mar 3, 2021
…ock the search for SIA and ICCREA (for test only) (#2862)"

This reverts commit 8f29540.
@fabriziofff fabriziofff deleted the 177187748-enable-iccrea-and-sia-cobadge-services branch January 21, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants