Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#176578322] Visualize iteratively co-badge card that can be added to the wallet #2770

Merged
merged 79 commits into from
Feb 4, 2021

Conversation

debiff
Copy link
Contributor

@debiff debiff commented Feb 2, 2021

Short description

This PR add the screen and the components that allows to view the co-badge card of the user that can be added to the wallet and the loading screen.

List of changes proposed in this pull request

  • Added AddCoBadgeComponent
  • Refactor the CoBadgeCard component
  • Added a BaseCoBadgeCard component
  • Added a PreviewCoBadgeCard component
  • Added an utils that allow to get the card icon from the brand
saveCard.mov

Blocked Card

Loading Screen

debiff and others added 30 commits January 22, 2021 12:39
@pagopa-github-bot pagopa-github-bot changed the title [#176578322] Visualize iteratively co-badge card that can be added to the wallet feat(Bonus Pagamenti Digitali): [#176578322] Visualize iteratively co-badge card that can be added to the wallet Feb 2, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Feb 2, 2021

Affected stories

  • 🌟 #176578322: Come CIT voglio visualizzare le mie carte di circuito internazione che è possibile aggiungere al wallet

Generated by 🚫 dangerJS against 279316b

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #2770 (279316b) into master (4b6611f) will increase coverage by 0.03%.
The diff coverage is 67.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2770      +/-   ##
==========================================
+ Coverage   53.87%   53.90%   +0.03%     
==========================================
  Files         795      799       +4     
  Lines       22033    22103      +70     
  Branches     4160     4171      +11     
==========================================
+ Hits        11870    11915      +45     
- Misses      10107    10132      +25     
  Partials       56       56              
Impacted Files Coverage Δ
...g/cobadge/screens/add-account/AddCoBadgeScreen.tsx 34.04% <33.33%> (-3.46%) ⬇️
.../features/wallet/cobadge/component/CoBadgeCard.tsx 37.50% <37.50%> (ø)
...obadge/screens/add-account/AddCobadgeComponent.tsx 67.64% <67.64%> (ø)
...es/wallet/cobadge/component/PreviewCoBadgeCard.tsx 75.00% <75.00%> (ø)
ts/utils/card.ts 80.00% <80.00%> (ø)
...tures/wallet/cobadge/component/BaseCoBadgeCard.tsx 96.66% <92.30%> (ø)
...ures/wallet/cobadge/screen/CobadgeDetailScreen.tsx 67.64% <100.00%> (+1.93%) ⬆️
...ge/screens/add-account/LoadAddCoBadgeComponent.tsx 54.54% <100.00%> (+4.54%) ⬆️
ts/utils/paymentMethod.ts 82.27% <100.00%> (+0.69%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b6611f...279316b. Read the comment docs.

@fabriziofff fabriziofff requested a review from thisisjp as a code owner February 4, 2021 12:59
@fabriziofff fabriziofff merged commit 187b665 into master Feb 4, 2021
@fabriziofff fabriziofff deleted the 176578322-add-iteratively-cobadge branch January 21, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants