feat(Carta Giovani Nazionale): [#176456924,#176655324,#176655351,#176655437,#176655260,#176655162,#176456839] Adds UI on CGN activation workflow #2758
Conversation
Co-authored-by: Matteo Boschi <[email protected]>
Co-authored-by: Matteo Boschi <[email protected]>
Co-authored-by: fabriziofff <[email protected]>
Co-authored-by: fabriziofff <[email protected]>
Co-authored-by: fabriziofff <[email protected]>
Co-authored-by: fabriziofff <[email protected]>
…76443215-request-cgn-activation
…b.com:pagopa/io-app into 176715047-request-cgn-status
| ); | ||
|
|
||
| const mapStateToProps = (_: GlobalState) => ({}); | ||
| const mapStateToProps = (state: GlobalState) => ({ | ||
| isLoading: isCgnActivationLoading(state) |
There was a problem hiding this comment.
With this condition, after the first error, if the user choose to retry it will not see the loading screen because the value in the store always remains the same (in the store section bonus.cgn.activation.status value will be ERROR).
Registrazione.schermo.2021-02-23.alle.18.57.00.mov
in the attached video I added a consistent delay to the dev server and made the api return error.
How about making the loading condition based on a section of the store that takes into account the start of a new request and its outcome?
There was a problem hiding this comment.
Ok I got the point, this store section is yet used only for Activation progress state, after the implementation of #2812 we have another API for the CGN activation status polling
What about setting the activation state to
{
...state,
status: CgnActivationProgressEnum.PROGRESS
};when we dispatch the cgnRequestActivation.request action?
There was a problem hiding this comment.
Pushed this solution in ff0cff3
And now it shows back the loader when retrying the activation
THIS PR DEPENDS ON #2773
Short description
This PR introduces UI on screens for CGN Activation flow
How to test
Change response on io-dev-server based this PR
Loading and Timeout
Registrazione.schermo.2021-01-28.alle.15.36.08.mov
Already Active
Pending
Ineligible
Error Loading