feat(Bonus Pagamenti Digitali): [#175741693] Remove timestamp from transactions when it's equal to 00:00 #2734
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import { getSubtitle } from "../BpdTransactionItem"; | ||
| import { EnhancedBpdTransaction } from "../../../components/transactionItem/BpdTransactionItem"; | ||
| import { HPan } from "../../../store/actions/paymentMethods"; | ||
| import { AwardPeriodId } from "../../../store/actions/periods"; | ||
|
|
||
| describe("Test how the transaction subtitle changes with different timestamps", () => { | ||
| it("Subtitle shouldn't contain hours and minutes, when the transaction has a timestamp 00:00", () => { | ||
| const myTransaction: EnhancedBpdTransaction = { | ||
| hashPan: "0d4194712c5d820fcbbb2e7ba199e15f73cfd43f8fe49f0aa62e7901253506df" as HPan, | ||
| idTrxAcquirer: "10126487773E", | ||
| idTrxIssuer: "R64692", | ||
| amount: 87.79, | ||
| awardPeriodId: 2 as AwardPeriodId, | ||
| image: 29, | ||
| maxCashbackForTransactionAmount: 15, | ||
| title: "xxxxxxx", | ||
| trxDate: new Date("2100-12-17T00:00"), | ||
| keyId: "xxxxxxxxx", | ||
| cashback: 8.779, | ||
| circuitType: "Mastercard" | ||
| }; | ||
|
|
||
| expect(getSubtitle(myTransaction)).toMatch("€ 87.79 · 17 Dec "); | ||
| }); | ||
|
|
||
| it("Subtitle should contain hours and minutes when the transaction has a timestamp 00:00", () => { | ||
| const myTransaction: EnhancedBpdTransaction = { | ||
| hashPan: "0d4194712c5d820fcbbb2e7ba199e15f73cfd43f8fe49f0aa62e7901253506df" as HPan, | ||
| idTrxAcquirer: "10126487773E", | ||
| idTrxIssuer: "R64692", | ||
| amount: 100000.79, | ||
| awardPeriodId: 2 as AwardPeriodId, | ||
| image: 29, | ||
| maxCashbackForTransactionAmount: 15, | ||
| title: "xxxxxxx", | ||
| trxDate: new Date("2100-12-19T12:39"), | ||
| keyId: "xxxxxxxxx", | ||
| cashback: 8.779, | ||
| circuitType: "Mastercard" | ||
| }; | ||
|
|
||
| expect(getSubtitle(myTransaction)).toMatch("€ 100,000.79 · 19 Dec, 12:39 "); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| // import { debug } from "console"; | ||
| import * as React from "react"; | ||
| import { render } from "@testing-library/react-native"; | ||
| import { BpdTransactionDetailComponent } from "../BpdTransactionDetailComponent"; | ||
| import { EnhancedBpdTransaction } from "../../../../../components/transactionItem/BpdTransactionItem"; | ||
| import { HPan } from "../../../../../store/actions/paymentMethods"; | ||
| import { AwardPeriodId } from "../../../../../store/actions/periods"; | ||
|
|
||
| describe("Test Transaction Timestamp", () => { | ||
| it("It should render label 'Date' and a value without hours and minutes when the transaction has a timestamp 00:00", () => { | ||
| const myTransaction: EnhancedBpdTransaction = { | ||
| hashPan: "0d4194712c5d820fcbbb2e7ba199e15f73cfd43f8fe49f0aa62e7901253506df" as HPan, | ||
| idTrxAcquirer: "10126487773E", | ||
| idTrxIssuer: "R64692", | ||
| amount: 87.79, | ||
| awardPeriodId: 2 as AwardPeriodId, | ||
| image: 29, | ||
| maxCashbackForTransactionAmount: 15, | ||
| title: "xxxxxxx", | ||
| trxDate: new Date("2100-12-17T00:00"), | ||
| keyId: "xxxxxxxxx", | ||
| cashback: 8.779, | ||
| circuitType: "Mastercard" | ||
| }; | ||
|
|
||
| // cut : Component Under Test | ||
| const cut = render( | ||
| <BpdTransactionDetailComponent transaction={myTransaction} /> | ||
| ); | ||
|
|
||
| const dateLabel = cut.getByTestId("dateLabel"); | ||
| const dateValue = cut.getByTestId("dateValue"); | ||
|
|
||
| expect(dateLabel.children[0]).toMatch(/Date/); | ||
| expect(dateValue.children[0]).toMatch(/17 Dec 2100/); | ||
| }); | ||
|
|
||
| it("It should render label 'Date and time' and a vale woth hours and minutes when the transaction has a timestamp different from 00:00 ", () => { | ||
| const myTransaction: EnhancedBpdTransaction = { | ||
| hashPan: "0d4194712c5d820fcbbb2e7ba199e15f73cfd43f8fe49f0aa62e7901253506df" as HPan, | ||
| idTrxAcquirer: "10126487773E", | ||
| idTrxIssuer: "R64692", | ||
| amount: 87.79, | ||
| awardPeriodId: 2 as AwardPeriodId, | ||
| image: 29, | ||
| maxCashbackForTransactionAmount: 0, | ||
| title: "xxxxxxx", | ||
| trxDate: new Date("2100-12-17T01:00"), | ||
| keyId: "xxxxxxxxx", | ||
| cashback: 8.779, | ||
| circuitType: "Mastercard" | ||
| }; | ||
|
|
||
| // cut : Component Under Test | ||
| const cut = render( | ||
| <BpdTransactionDetailComponent transaction={myTransaction} /> | ||
| ); | ||
| const dateLabel = cut.getByTestId("dateLabel"); | ||
| const dateValue = cut.getByTestId("dateValue"); | ||
|
|
||
| expect(dateLabel.children[0]).toMatch(/Date and time/); | ||
| expect(dateValue.children[0]).toMatch(/17 Dec 2100, 01:00/); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you think about adding also the seconds to the calculation?
In this way we can render the time for a transaction with timestamp
2020-12-13T00:00:31+01:00that is a valid transaction.