feat(Bonus Pagamenti Digitali): [#175890963] Adds the screen to see all BPay accounts to add #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…863-bpay-search-screen
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2697 +/- ##
=======================================
Coverage 51.96% 51.97%
=======================================
Files 755 756 +1
Lines 21268 21289 +21
Branches 4043 4043
=======================================
+ Hits 11052 11065 +13
- Misses 10172 10180 +8
Partials 44 44
Continue to review full report at Codecov.
|
Undermaken
suggested changes
Jan 11, 2021
| elem => elem.abi === props.account.instituteCode | ||
| ); | ||
| setAbiInfo(abi ?? {}); | ||
| }, [props.currentIndex]); |
There was a problem hiding this comment.
Since we search for Abi when account changes, could it be better if the effect depends on props.account instead of currentIndex?
For this implementation it is the same but if who uses this component changes the currentIndex and not props.account it will be fired when it's not needed
Undermaken
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the screen to cycle through the BPay accounts to add
Registrazione.schermo.2021-01-11.alle.09.17.09.mov