-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Bonus Pagamenti Digitali): [#176191528,#176269223] Supercashback graphical component and textual summary update #2633
Conversation
…528-supercashback-graphical-component-and-textual-summary-update
…t-and-textual-summary-update
Affected stories
|
…back-graphical-component-and-textual-summary-update' into 176191528-supercashback-graphical-component-and-textual-summary-update
Codecov Report
@@ Coverage Diff @@
## master #2633 +/- ##
==========================================
+ Coverage 50.93% 51.05% +0.11%
==========================================
Files 716 720 +4
Lines 20456 20515 +59
Branches 3613 3940 +327
==========================================
+ Hits 10420 10473 +53
- Misses 9992 9998 +6
Partials 44 44
Continue to review full report at Codecov.
|
…t-and-textual-summary-update
…back-graphical-component-and-textual-summary-update' into 176191528-supercashback-graphical-component-and-textual-summary-update
precision: 0, | ||
delimiter: I18n.t("global.localization.delimiterSeparator"), | ||
separator: I18n.t("global.localization.decimalSeparator") | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some test here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in e2b97cc
* @param props | ||
* @constructor | ||
*/ | ||
export const TextualSummary = (props: Props) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you think about use React.ReactElement
as return type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, added in 1b961af
* @param props | ||
* @constructor | ||
*/ | ||
export const InactiveTextualSummary = (props: { period: BpdPeriod }) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you think about use React.ReactElement
as return type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in 1b961af
); | ||
} | ||
// The max cashback amount is reached | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this curly brackets are needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed in 1b961af
…528-supercashback-graphical-component-and-textual-summary-update
…t-and-textual-summary-update
…t-and-textual-summary-update
…t-and-textual-summary-update
…t-and-textual-summary-update
Short description
This pr adds the Supercashback graphical component and update the textual summary conditions for the
Active
state.Warning && transactionNumber==0
Warning && transactionNumber > 0
Unlock
MaxAmount
SuperCashback
List of changes proposed in this pull request
superCashbackAmount
inBpdPeriod
BpdSummaryComponent
in order to display the supercashback ranking preview itemSuperCashbackRankingSummary
PercentageTransactionsSummary
TextualSummary
and added new textual statesformatIntegerNumber
to format an integer with delimiterHow to test
ts/features/bonus/bpd/screens/details/components/summary/__test__/bpdSummaryComponent.test.tsx