Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#176167278] Show message when remove profile if some bonus is active #2597

Merged
merged 20 commits into from
Dec 23, 2020

Conversation

debiff
Copy link
Contributor

@debiff debiff commented Dec 15, 2020

Short description

This PR show an alert to inform the user that has some bonus active when choice to remove the profile.
If the user hasn't any active bonus the flow it's unchanged.

List of changes proposed in this pull request

  • Added alert if the user that are deleting the profile has at least one active bonus
    -Request bonus information with a new saga if the user are deleting his profile and the bonus information aren't loaded yet.

@pagopa-github-bot pagopa-github-bot changed the title [#176167278] Show message when remove profile if some bonus is active feat: [#176167278] Show message when remove profile if some bonus is active Dec 15, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 15, 2020

Affected stories

  • 🌟 #176167278: Come CIT che decide di eliminare il proprio profilo, voglio sapere se i miei bonus verranno cancellati contestualmente

Generated by 🚫 dangerJS against cf6690e

@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #2597 (cf6690e) into master (d3b11ca) will decrease coverage by 0.01%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2597      +/-   ##
==========================================
- Coverage   50.76%   50.74%   -0.02%     
==========================================
  Files         711      711              
  Lines       20289    20325      +36     
  Branches     3899     3582     -317     
==========================================
+ Hits        10299    10314      +15     
- Misses       9946     9967      +21     
  Partials       44       44              
Impacted Files Coverage Δ
ts/screens/profile/RemoveAccountDetailsScreen.tsx 41.17% <21.73%> (-4.11%) ⬇️
ts/sagas/profile.ts 33.75% <43.75%> (+2.40%) ⬆️
ts/screens/profile/RemoveAccountInfoScreen.tsx 65.21% <50.00%> (-9.79%) ⬇️
ts/sagas/startup.ts 54.24% <100.00%> (+0.35%) ⬆️
ts/store/actions/navigation.ts 100.00% <100.00%> (ø)
ts/store/actions/profile.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3b11ca...cf6690e. Read the comment docs.

ts/sagas/startup.ts Outdated Show resolved Hide resolved
ts/sagas/startup.ts Outdated Show resolved Hide resolved
ts/sagas/profile.ts Show resolved Hide resolved
ts/screens/profile/RemoveAccountInfoScreen.tsx Outdated Show resolved Hide resolved
@debiff debiff requested a review from Undermaken December 16, 2020 13:53
}
};

const handleSendMotivaiton = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const handleSendMotivaiton = (
const handleSendMotivation = (

ts/store/actions/profile.ts Show resolved Hide resolved
@debiff debiff requested a review from Undermaken December 16, 2020 21:02
@Undermaken Undermaken merged commit 9b4d556 into master Dec 23, 2020
@Undermaken Undermaken deleted the 176167278-bonus-message-delete-profile branch December 23, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants