Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#175909052] Display only internal payment methods #2471

Merged
merged 9 commits into from
Dec 3, 2020

Conversation

fabriziofff
Copy link
Contributor

Short description

This pr allows to see in the wallet only the payment methods onboarded on IO or WISP.

List of changes proposed in this pull request

  • Created new *VisibleInWalletSelector selectors for Credit Card, Bancomay, Satispay and BancomatPay.
  • Changed WalletV2PreviewCards.tsx selector with the new one

How to test

  • case 1: bancomat, satispay with onboardingChannel === "WISP" or "IO" should visible in wallet
  • case 2: bancomat, satispay with onboardingChannel !== "WISP" or "IO" should not be visible in wallet

@pagopa-github-bot pagopa-github-bot changed the title [#175909052] Display only internal payment methods feat(Bonus Pagamenti Digitali): [#175909052] Display only internal payment methods Dec 1, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 1, 2020

Affected stories

  • 🌟 #175909052: Come CIT voglio vedere nel wallet solo i metodi di pagamento NON aggiunti da altro canale

Generated by 🚫 dangerJS against ae0e485

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #2471 (ae0e485) into master (10ce988) will decrease coverage by 0.01%.
The diff coverage is 43.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2471      +/-   ##
==========================================
- Coverage   50.59%   50.58%   -0.02%     
==========================================
  Files         700      700              
  Lines       19683    19697      +14     
  Branches     3806     3497     -309     
==========================================
+ Hits         9958     9963       +5     
- Misses       9679     9688       +9     
  Partials       46       46              
Impacted Files Coverage Δ
...nents/paymentMethod/WalletPaymentMethodBpdList.tsx 62.85% <ø> (ø)
...features/wallet/component/WalletV2PreviewCards.tsx 71.42% <ø> (ø)
ts/store/reducers/wallet/wallets.ts 49.61% <35.71%> (-1.70%) ⬇️
.../screens/onboarding/EnrollPaymentMethodsScreen.tsx 62.85% <100.00%> (ø)
...tures/bonus/bpd/store/reducers/details/combiner.ts 61.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10ce988...ae0e485. Read the comment docs.

@Undermaken Undermaken merged commit e5eb533 into master Dec 3, 2020
@Undermaken Undermaken deleted the 175909052-display-only-internal-payment-methods branch December 3, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants