Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Bonus Pagamenti Digitali): [#175934342] Onboarding credit card failure instead of success #2459

Merged
merged 6 commits into from
Dec 1, 2020
Merged

fix(Bonus Pagamenti Digitali): [#175934342] Onboarding credit card failure instead of success #2459

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
71e50f7
[#175934342] fix
Undermaken Nov 30, 2020
fcab19c
Merge branch 'master' into 175934342-fix-false-negative
CrisTofani Nov 30, 2020
269fbfa
Merge branch 'master' into 175934342-fix-false-negative
Undermaken Dec 1, 2020
586846b
Merge branch 'master' into 175934342-fix-false-negative
Undermaken Dec 1, 2020
88d6634
Merge branch 'master' into 175934342-fix-false-negative
CrisTofani Dec 1, 2020
2607327
Merge branch 'master' into 175934342-fix-false-negative
CrisTofani Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ts/sagas/wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,8 @@ function* startOrResumeAddCreditCardSaga(
const bpdEnroll: ReturnType<typeof bpdEnabledSelector> = yield select(
bpdEnabledSelector
);
// dispatch the action: a new card has been added
yield put(addWalletNewCreditCardSuccess());
// check if the new method is compliant with bpd
if (bpdEnabled) {
const hasBpdFeature = hasFunctionEnabled(
Expand Down Expand Up @@ -363,9 +365,6 @@ function* startOrResumeAddCreditCardSaga(
return;
}
}

// dispatch the action: a new card has been added
yield put(addWalletNewCreditCardSuccess());
if (action.payload.setAsFavorite === true) {
yield put(setFavouriteWalletRequest(maybeAddedWallet.idWallet));
}
Expand Down