Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#175883778,#175883201,#175883970] Onboard Satispay account orchestration #2444

Merged
merged 43 commits into from
Dec 1, 2020

Conversation

fabriziofff
Copy link
Contributor

@fabriziofff fabriziofff commented Nov 26, 2020

This pr depends on #2443

Short description

This pr adds the saga & workflow to add a Satispay account to the wallet.

List of changes proposed in this pull request

  • fixed the wrong header title visualization for ActivateBpdOnNewPaymentMethodScreen
  • changed the response decoder for POST /v1/satispay/add-wallet (expected PatchedWalletV2Response)
  • start the Satispay onboarding then tap the item "Satispay" in "digital payment methods"
  • created new common workflow activateBpdOnNewPaymentMethods
  • changed handleSearchUserSatispay (should return value.data)
  • changed handleAddUserSatispayToWallet in order to return a RawSatispayPaymentMethod with the action
  • added addSatispayToWallet to handle all the workflow of Satispay onboarding.

How to test

Test the onboarding using the dev server and choosing "Satispay" from "digital payment methods"

@pagopa-github-bot pagopa-github-bot changed the title [#175883778] Onboard satispay account orchestration feat(Bonus Pagamenti Digitali): [#175883778] Onboard satispay account orchestration Nov 26, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 26, 2020

Affected stories

  • 🌟 #175883778: Come CIT voglio fare l'onboarding del mio account Satispay
  • 🌟 #175883201: Come CIT voglio iniziare l'onboarding di Satispay quando seleziono l'item dalla lista dei "pagamenti digitali"
  • 🌟 #175883970: Come CIT voglio poter attivare il cashback sull'account Satispay appena aggiunto

Generated by 🚫 dangerJS against 362fbb0

@codecov-io
Copy link

codecov-io commented Nov 27, 2020

Codecov Report

Merging #2444 (362fbb0) into master (9b73c1f) will increase coverage by 0.20%.
The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2444      +/-   ##
==========================================
+ Coverage   50.23%   50.44%   +0.20%     
==========================================
  Files         680      695      +15     
  Lines       19337    19590     +253     
  Branches     3462     3796     +334     
==========================================
+ Hits         9714     9882     +168     
- Misses       9577     9662      +85     
  Partials       46       46              
Impacted Files Coverage Δ
ts/api/pagopa.ts 30.64% <ø> (ø)
...creens/bpd/ActivateBpdOnNewPaymentMethodScreen.tsx 84.21% <0.00%> (ø)
.../wallet/onboarding/satispay/store/actions/index.ts 100.00% <ø> (ø)
ts/navigation/routes.ts 100.00% <ø> (ø)
...allet/onboarding/satispay/saga/networking/index.ts 29.62% <37.50%> (-2.38%) ⬇️
ts/utils/walletv2.ts 81.81% <42.85%> (-7.93%) ⬇️
...pay/screens/search/SearchSatispayManagerScreen.tsx 54.16% <47.61%> (ø)
...bancomat/saga/orchestration/addBancomatToWallet.ts 52.00% <50.00%> (+7.88%) ⬆️
...archBancomat/SearchAvailableUserBancomatScreen.tsx 55.55% <50.00%> (+1.26%) ⬆️
...satispay/saga/orchestration/addSatispayToWallet.ts 50.00% <50.00%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b73c1f...362fbb0. Read the comment docs.

@fabriziofff fabriziofff changed the title feat(Bonus Pagamenti Digitali): [#175883778] Onboard satispay account orchestration feat(Bonus Pagamenti Digitali): [#175883778] Onboard Satispay account orchestration Nov 29, 2020
@fabriziofff fabriziofff marked this pull request as ready for review November 29, 2020 19:27
@fabriziofff fabriziofff changed the title feat(Bonus Pagamenti Digitali): [#175883778] Onboard Satispay account orchestration feat(Bonus Pagamenti Digitali): [#175883778,#175883201] Onboard Satispay account orchestration Nov 30, 2020
@fabriziofff fabriziofff changed the title feat(Bonus Pagamenti Digitali): [#175883778,#175883201] Onboard Satispay account orchestration feat(Bonus Pagamenti Digitali): [#175883778,#175883201,#175883970] Onboard Satispay account orchestration Nov 30, 2020
locales/en/index.yml Outdated Show resolved Hide resolved
locales/en/index.yml Outdated Show resolved Hide resolved
);
const SearchSatispayManagerScreen: React.FunctionComponent<Props> = props => {
const satispay = props.foundSatispay;
if (isError(satispay) && satispay.error.kind === "timeout") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we often check about this error
what about this?

ts/utils/errors.ts

export const isTimoutError = (error: NetworkError): error is TimeoutError =>
  error.kind === "timeout";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in 271169c !

ts/utils/walletv2.ts Show resolved Hide resolved
Undermaken and others added 12 commits November 30, 2020 14:37
Co-authored-by: Matteo Boschi <[email protected]>
Co-authored-by: Matteo Boschi <[email protected]>
…atispay-account' into 175883778-onboard-satispay-account
@Undermaken Undermaken merged commit 48b6d91 into master Dec 1, 2020
@Undermaken Undermaken deleted the 175883778-onboard-satispay-account branch December 1, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants