-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Bonus Pagamenti Digitali): [#175883778,#175883201,#175883970] Onboard Satispay account orchestration #2444
Conversation
Affected stories
|
…764-satispay-screens-and-navigation
… into 175883778-onboard-satispay-account
Codecov Report
@@ Coverage Diff @@
## master #2444 +/- ##
==========================================
+ Coverage 50.23% 50.44% +0.20%
==========================================
Files 680 695 +15
Lines 19337 19590 +253
Branches 3462 3796 +334
==========================================
+ Hits 9714 9882 +168
- Misses 9577 9662 +85
Partials 46 46
Continue to review full report at Codecov.
|
…764-satispay-screens-and-navigation
…screens-and-navigation' into 175883764-satispay-screens-and-navigation
… into 175883778-onboard-satispay-account
…screens-and-navigation' into 175883778-onboard-satispay-account
…screens-and-navigation' into 175883778-onboard-satispay-account
…75883764-satispay-screens-and-navigation
… of github.com:pagopa/io-app into 175883778-onboard-satispay-account
ts/features/bonus/bpd/saga/orchestration/activateBpdOnNewAddedPaymentMethods.ts
Outdated
Show resolved
Hide resolved
ts/features/bonus/bpd/saga/orchestration/activateBpdOnNewAddedPaymentMethods.ts
Outdated
Show resolved
Hide resolved
ts/features/wallet/onboarding/satispay/store/reducers/foundSatispay.ts
Outdated
Show resolved
Hide resolved
ts/features/wallet/onboarding/satispay/screens/search/SatispayKoNotFound.tsx
Show resolved
Hide resolved
ts/features/wallet/onboarding/satispay/screens/search/SatispayKoTimeout.tsx
Show resolved
Hide resolved
); | ||
const SearchSatispayManagerScreen: React.FunctionComponent<Props> = props => { | ||
const satispay = props.foundSatispay; | ||
if (isError(satispay) && satispay.error.kind === "timeout") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we often check about this error
what about this?
ts/utils/errors.ts
export const isTimoutError = (error: NetworkError): error is TimeoutError =>
error.kind === "timeout";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added in 271169c !
ts/features/wallet/onboarding/satispay/store/reducers/addedSatispay.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Matteo Boschi <[email protected]>
Co-authored-by: Matteo Boschi <[email protected]>
…PaymentMethods.ts Co-authored-by: Matteo Boschi <[email protected]>
…PaymentMethods.ts Co-authored-by: Matteo Boschi <[email protected]>
…ispay.ts Co-authored-by: Matteo Boschi <[email protected]>
…KoNotFound.tsx Co-authored-by: Matteo Boschi <[email protected]>
…KoTimeout.tsx Co-authored-by: Matteo Boschi <[email protected]>
…atispay-account' into 175883778-onboard-satispay-account
…ispay.ts Co-authored-by: Matteo Boschi <[email protected]>
This pr depends on #2443
Short description
This pr adds the saga & workflow to add a Satispay account to the wallet.
List of changes proposed in this pull request
ActivateBpdOnNewPaymentMethodScreen
POST /v1/satispay/add-wallet
(expectedPatchedWalletV2Response
)activateBpdOnNewPaymentMethods
handleSearchUserSatispay
(should return value.data)handleAddUserSatispayToWallet
in order to return aRawSatispayPaymentMethod
with the actionaddSatispayToWallet
to handle all the workflow of Satispay onboarding.How to test
Test the onboarding using the dev server and choosing "Satispay" from "digital payment methods"