-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Bonus Pagamenti Digitali): [#175797662] Display bancomat abi logo #2442
Conversation
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2442 +/- ##
==========================================
+ Coverage 50.07% 50.10% +0.02%
==========================================
Files 672 673 +1
Lines 19170 19181 +11
Branches 3752 3751 -1
==========================================
+ Hits 9600 9611 +11
Misses 9524 9524
Partials 46 46
Continue to review full report at Codecov.
|
…bi-image' into 175797662-display-abi-image
ts/utils/paymentMethod.ts
Outdated
caption: getTitleFromBancomat(bancomat, abiList), | ||
icon: getImageFromPaymentMethod(bancomat) | ||
icon: getImageFromPaymentMethod(bancomat), | ||
listIcon: pagoBancomatImage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icon
field should represent the icon that in the case of the bancomat should remain the "bancomat" icon and we can avoid to add another field listIcon
.
Could we move the new bank logo information in BancomatPaymentMethod.abiInfo.logoUrl
?
All the existing code should be fine after this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be a smarter injection 👍🏼
I'm going to try....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabriziofff
I changed the code as required: now the abi selector gives back an enhanced abi with logoUrl
pointing out CDN
In this way if we need the abi logo, that info is available inside abi and not only in the enhanced bancomat (enhanced bancomat includes the abi itself)
Short description
This PR displays the bancomat abi logo as a remote resource
A list of abi images are been added to our CDN
how to test:
CDN will be sync tomorrow (27th November) so you can change your .env settings as follows
CONTENT_REPO_URL='https://raw.githubusercontent.com/pagopa/io-services-metadata/master'
note
for bancomat displayed as a toggle item, we prefer the bancomat logo instead of abi logo
see https://www.pivotaltracker.com/story/show/175797662/comments/220045266