Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Bonus Pagamenti Digitali): [#175700724] Fixes wrong format of bpd amount #2376

Merged
merged 4 commits into from
Nov 16, 2020

Conversation

CrisTofani
Copy link
Contributor

Short description

This pr fixes the formattation error of the BPD amount on cards. The character used for splitting and displayed inside card is now localized

image

@pagopa-github-bot pagopa-github-bot changed the title [#175700724] Fixes wrong format of bpd amount fix(Bonus Pagamenti Digitali): [#175700724] Fixes wrong format of bpd amount Nov 12, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 12, 2020

Affected stories

  • 🐞 #175700724: [minor] Formattazione errata dell'importo del cashback quando è attiva la lingua inglese

Generated by 🚫 dangerJS against 8c0efcf

@codecov-io
Copy link

codecov-io commented Nov 16, 2020

Codecov Report

Merging #2376 (001904c) into master (bf78f97) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2376      +/-   ##
==========================================
+ Coverage   49.95%   49.98%   +0.02%     
==========================================
  Files         652      652              
  Lines       18334    18317      -17     
  Branches     3580     3282     -298     
==========================================
- Hits         9159     9155       -4     
+ Misses       9128     9115      -13     
  Partials       47       47              
Impacted Files Coverage Δ
...d/components/bpdCardComponent/BpdCardComponent.tsx 38.09% <0.00%> (ø)
ts/utils/stringBuilder.ts 88.88% <ø> (ø)
...bonus/bpd/store/reducers/details/paymentMethods.ts 45.71% <0.00%> (+0.97%) ⬆️
...s/bonus/bpd/store/reducers/details/transactions.ts 60.00% <0.00%> (+2.85%) ⬆️
...atures/bonus/bpd/store/reducers/details/amounts.ts 82.14% <0.00%> (+4.72%) ⬆️
...t/bancomat/component/bancomatCard/BancomatCard.tsx 80.00% <0.00%> (+30.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf78f97...8c0efcf. Read the comment docs.

@Undermaken Undermaken merged commit 1d6183b into master Nov 16, 2020
@CrisTofani CrisTofani deleted the 175700724-fix-cashback-formatting branch March 23, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants