-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [#175659067] Using placeholder in yaml/locale #2363
Conversation
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2363 +/- ##
=======================================
Coverage 48.87% 48.87%
=======================================
Files 633 633
Lines 17763 17763
Branches 3502 3502
=======================================
Hits 8682 8682
Misses 9039 9039
Partials 42 42 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using multiple reference inside a string it fails to retrieve all the dependecies.
With this test:
card:
a: "ciao "
b: "${bonus.bpd.details.card.a} ${bonus.bpd.details.card.a}"
The output is:
It could be a common case, often in very long texts the same key can be repeated several times (eg. bonus vacanze).
…eholders' into 175659067-yaml-placeholders
@fabriziofff absolutely, this is a bug! |
Short description
This PR tries to improve the locales generation with the usage of placeholders.
Now you can refer to a value already defined in the
yaml
as a placeholder. That placeholder will be replaced with relative value on runningyarn generate:locales
commandhow to use this feature
Often your text includes the same word. Now you can refer to it with a placeholder
generated locales will be