Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#174863016] Enroll payment methods to bpd while onboarding #2301

Merged
merged 46 commits into from
Oct 23, 2020

Conversation

fabriziofff
Copy link
Contributor

@fabriziofff fabriziofff commented Oct 16, 2020

This pr depends on #2298

Short description

This pr adds the business logic and refines the EnrollPaymentMethodsScreen.

EnrollPaymentMethodsScreen User flow

List of changes proposed in this pull request

  • Added PaymentMethodBpdList to render a ReadonlyArray<Wallet> (to be completed after v2 wallet).
  • Changed business logic of insertIban.ts. Now when the wallets are pot.some and length>0 navigate to EnrollPaymentMethodsScreen.
  • Added EnrollPaymentMethodsScreen contents and logic.

How to test

Complete the bpd onboarding flow with at least one payment method into the wallet.

@pagopa-github-bot pagopa-github-bot changed the title [#174863016] Enroll payment methods to bpd while onboarding feat(Bonus Pagamenti Digitali): [#174863016] Enroll payment methods to bpd while onboarding Oct 16, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 16, 2020

Affected stories

  • 🌟 #174863016: Come CIT voglio poter fare l'enroll di bpd sui miei metodi di pagamento in fase di onboarding

Generated by 🚫 dangerJS against f238ebb

@fabriziofff fabriziofff marked this pull request as ready for review October 16, 2020 18:11
@codecov-io
Copy link

codecov-io commented Oct 19, 2020

Codecov Report

Merging #2301 into master will decrease coverage by 0.02%.
The diff coverage is 56.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2301      +/-   ##
==========================================
- Coverage   47.73%   47.71%   -0.03%     
==========================================
  Files         570      573       +3     
  Lines       16478    16595     +117     
  Branches     3298     3316      +18     
==========================================
+ Hits         7866     7918      +52     
- Misses       8570     8635      +65     
  Partials       42       42              
Impacted Files Coverage Δ
...tMethodActivationToggle/PaymentMethodBpdToggle.tsx 36.20% <ø> (ø)
...eatures/bonus/bpd/saga/orchestration/insertIban.ts 43.24% <27.27%> (-5.04%) ⬇️
.../screens/onboarding/EnrollPaymentMethodsScreen.tsx 61.76% <59.37%> (-38.24%) ⬇️
...ures/bonus/bpd/components/PaymentMethodBpdList.tsx 83.33% <83.33%> (ø)
ts/features/bonus/bpd/navigation/navigator.ts 100.00% <100.00%> (ø)
...onents/paymentMethodActivationToggle/BpdToggle.tsx 46.66% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af65bdf...550846e. Read the comment docs.

Undermaken and others added 17 commits October 20, 2020 08:58
…method-component' into 174863016-EnrollPaymentMethodsScreen
@Undermaken Undermaken merged commit b26fe2d into master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants