-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Bonus Pagamenti Digitali): [#174863016] Enroll payment methods to bpd while onboarding #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-on-payment-method-component
…d-on-payment-method-component
…d-on-payment-method-component
…d-on-payment-method-component
pagopa-github-bot
changed the title
[#174863016] Enroll payment methods to bpd while onboarding
feat(Bonus Pagamenti Digitali): [#174863016] Enroll payment methods to bpd while onboarding
Oct 16, 2020
Affected stories
|
…method-component' into 174863016-EnrollPaymentMethodsScreen
fabriziofff
requested review from
francescopersico and
Undermaken
as code owners
October 16, 2020 18:11
…method-component' into 174863016-EnrollPaymentMethodsScreen
Codecov Report
@@ Coverage Diff @@
## master #2301 +/- ##
==========================================
- Coverage 47.73% 47.71% -0.03%
==========================================
Files 570 573 +3
Lines 16478 16595 +117
Branches 3298 3316 +18
==========================================
+ Hits 7866 7918 +52
- Misses 8570 8635 +65
Partials 42 42
Continue to review full report at Codecov.
|
…method-component' into 174863016-EnrollPaymentMethodsScreen
…174794326-174794981-bpd-payment-instruments
…d-on-payment-method-component
…174794326-174794981-bpd-payment-instruments
…-bpd-payment-instruments
…3016-EnrollPaymentMethodsScreen
…mentMethodsScreen
Undermaken
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr depends on #2298
Short description
This pr adds the business logic and refines the
EnrollPaymentMethodsScreen
.List of changes proposed in this pull request
PaymentMethodBpdList
to render aReadonlyArray<Wallet>
(to be completed after v2 wallet).insertIban.ts
. Now when the wallets arepot.some
andlength>0
navigate toEnrollPaymentMethodsScreen
.EnrollPaymentMethodsScreen
contents and logic.How to test
Complete the bpd onboarding flow with at least one payment method into the wallet.