Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#175204419] Connect search bank screen with onboarding bancomat business logic #2279

Merged

Conversation

fabriziofff
Copy link
Contributor

This pr depends on #2266

Short description

This pr links the real SearchBankScreen with the onboarding bancomat business logic.

fabriziofff and others added 30 commits September 29, 2020 10:41
@pagopa-github-bot pagopa-github-bot changed the title [#175204419] Connect search bank screen with onboarding bancomat business logic feat(Bonus Pagamenti Digitali): [#175204419] Connect search bank screen with onboarding bancomat business logic Oct 9, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 9, 2020

Affected stories

  • 🌟 #175204419: Collegare lo screen di ricerca banca al flusso generale di onboarding bancomat

Generated by 🚫 dangerJS against e31f02d

@codecov-io
Copy link

codecov-io commented Oct 9, 2020

Codecov Report

Merging #2279 into master will decrease coverage by 0.08%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2279      +/-   ##
==========================================
- Coverage   47.92%   47.84%   -0.09%     
==========================================
  Files         553      556       +3     
  Lines       15986    16076      +90     
  Branches     2930     2950      +20     
==========================================
+ Hits         7662     7691      +29     
- Misses       8282     8343      +61     
  Partials       42       42              
Impacted Files Coverage Δ
...onboarding/bancomat/components/BankPreviewItem.tsx 43.33% <0.00%> (ø)
...s/features/wallet/onboarding/bancomat/utils/abi.ts 20.00% <20.00%> (ø)
...ng/bancomat/screens/search/SearchBankComponent.tsx 32.60% <32.60%> (ø)
...allet/onboarding/bancomat/saga/networking/index.ts 30.00% <33.33%> (-3.34%) ⬇️
...rding/bancomat/screens/search/SearchBankScreen.tsx 55.55% <55.55%> (ø)
...wallet/onboarding/bancomat/navigation/navigator.ts 100.00% <100.00%> (ø)
ts/features/wallet/onboarding/store/abi.ts 46.42% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bed6ab5...b803e79. Read the comment docs.

@Undermaken Undermaken merged commit 54ca830 into master Oct 9, 2020
@Undermaken Undermaken deleted the 175204419-connect-search-bank-screen-with-onboarding-logic branch October 9, 2020 16:28
@Undermaken Undermaken restored the 175204419-connect-search-bank-screen-with-onboarding-logic branch October 9, 2020 16:28
@fabriziofff fabriziofff deleted the 175204419-connect-search-bank-screen-with-onboarding-logic branch January 21, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants