fix(Android): [#175090703] CTA text not aligned in the Android Bonus_Request_Information screen #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debiff
requested review from
CrisTofani,
fabriziofff,
francescopersico and
Undermaken
as code owners
pagopa-github-bot
changed the title
Affected stories
|
pagopa-github-bot
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2270 +/- ##
=========================================
Coverage ? 47.92%
=========================================
Files ? 543
Lines ? 15788
Branches ? 3159
=========================================
Hits ? 7566
Misses ? 8180
Partials ? 42
Continue to review full report at Codecov.
|
Undermaken
suggested changes
Oct 7, 2020
| @@ -108,6 +108,7 @@ const BonusInformationComponent: React.FunctionComponent<Props> = props => { | |||
| title: I18n.t("global.buttons.cancel") | |||
| }; | |||
| const requestButtonProps = { | |||
| buttonFontSize: customVariables.btnFontSize - 1, | |||
There was a problem hiding this comment.
For accessibility reasons I guess decrease the font-size is not a good idea.
Perhaps we can change the text and make it shorter
see https://www.pivotaltracker.com/story/show/175090703/comments/218618829
There was a problem hiding this comment.
Changed the label as suggested.
…equest-information-android' into 175090703-align-text-cta-bonus-request-information-android
Undermaken
approved these changes
Oct 9, 2020
fabriziofff
deleted the
175090703-align-text-cta-bonus-request-information-android
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR fix the alignment in the
Request bonusbutton of the Bonus_Request_Information screen on Android device.List of changes proposed in this pull request
Reduced by 1 point with respect to the standard size of the button the font size