Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#174838065] Declaration screen #2228

Merged
merged 63 commits into from
Sep 29, 2020

Conversation

fabriziofff
Copy link
Contributor

@fabriziofff fabriziofff commented Sep 25, 2020

Short description

This pr adds the declaration screen https://pagopa.invisionapp.com/console/IO---Cashback---attivazione-ckfc5u1ej0j3j013m2kw7gwvp/ckfdr382k02gp012b6y1sdgxf/play

List of changes proposed in this pull request

  • Created DeclarationComponent (graphical implementation) and DeclarationScreen (link the graphical implementation with the business logic).
  • Added core component CheckBox
  • Added layout common component InfoBox
  • Updated ShowRoom with new components
  • Changed FooterWithButtons to support disabled buttons (changed in this implementation, waiting to complete the core component that implements this functionality).
  • Added bpd section in locales

How to test

  • Start the flow from "Cashback pagamenti digitali"

@pagopa-github-bot pagopa-github-bot changed the title [#174838065] Declaration screen feat(Bonus Pagamenti Digitali): [#174838065] Declaration screen Sep 25, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Sep 25, 2020

Affected stories

  • 🌟 #174838065: Creare schermata per l'autodichiarazione per attivare bpd

Generated by 🚫 dangerJS against f1d25b7

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2020

Codecov Report

Merging #2228 into master will increase coverage by 0.08%.
The diff coverage is 66.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2228      +/-   ##
==========================================
+ Coverage   47.47%   47.55%   +0.08%     
==========================================
  Files         515      522       +7     
  Lines       15193    15282      +89     
  Branches     3073     3090      +17     
==========================================
+ Hits         7213     7268      +55     
- Misses       7939     7973      +34     
  Partials       41       41              
Impacted Files Coverage Δ
ts/components/TouchableDefaultOpacity.tsx 83.33% <ø> (ø)
...usVacanze/components/markdown/FooterTwoButtons.tsx 57.14% <0.00%> (-42.86%) ⬇️
ts/components/core/selection/CheckBox.tsx 40.00% <40.00%> (ø)
...Vacanze/components/buttons/ButtonConfigurations.ts 57.14% <50.00%> (-2.86%) ⬇️
...ns/onboarding/declaration/DeclarationComponent.tsx 54.54% <54.54%> (ø)
ts/components/box/InfoBox.tsx 72.72% <72.72%> (ø)
ts/components/core/selection/RawCheckBox.tsx 77.77% <77.77%> (ø)
...reens/onboarding/declaration/DeclarationScreen.tsx 77.77% <77.77%> (ø)
ts/components/core/accessibility.ts 83.33% <83.33%> (ø)
...creens/onboarding/declaration/DeclarationEntry.tsx 88.88% <88.88%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59fd59f...f1d25b7. Read the comment docs.

@Undermaken Undermaken merged commit 72cbca6 into master Sep 29, 2020
@Undermaken Undermaken deleted the 174838065-ResidenceDeclarationScreen branch September 29, 2020 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants