-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Bonus Pagamenti Digitali): [#174838065] Declaration screen #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rding-navigation-stack
…rding-navigation-stack
…rding-navigation-stack
…72-state-action-reducers-for-bpd-onboarding
…rding-navigation-stack
…72-state-action-reducers-for-bpd-onboarding
…rding-navigation-stack
…72-state-action-reducers-for-bpd-onboarding
…o 174839834-onboarding-saga-orchestration
…ion-reducers-for-bpd-onboarding
…o 174839834-onboarding-saga-orchestration
…g-saga-orchestration
fabriziofff
requested review from
francescopersico and
Undermaken
as code owners
September 25, 2020 16:00
pagopa-github-bot
changed the title
[#174838065] Declaration screen
feat(Bonus Pagamenti Digitali): [#174838065] Declaration screen
Sep 25, 2020
Affected stories
|
…g-saga-orchestration
Codecov Report
@@ Coverage Diff @@
## master #2228 +/- ##
==========================================
+ Coverage 47.47% 47.55% +0.08%
==========================================
Files 515 522 +7
Lines 15193 15282 +89
Branches 3073 3090 +17
==========================================
+ Hits 7213 7268 +55
- Misses 7939 7973 +34
Partials 41 41
Continue to review full report at Codecov.
|
Co-authored-by: Matteo Boschi <[email protected]>
Co-authored-by: Matteo Boschi <[email protected]>
…-ResidenceDeclarationScreen
…-ResidenceDeclarationScreen
…g-saga-orchestration
…-ResidenceDeclarationScreen
Undermaken
suggested changes
Sep 28, 2020
ts/features/bonus/bpd/screens/onboarding/declaration/DeclarationComponent.tsx
Outdated
Show resolved
Hide resolved
ts/features/bonus/bpd/screens/onboarding/declaration/DeclarationComponent.tsx
Show resolved
Hide resolved
…reen' into 174838065-ResidenceDeclarationScreen
…onComponent.tsx Co-authored-by: Matteo Boschi <[email protected]>
…reen' into 174838065-ResidenceDeclarationScreen
Undermaken
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pr adds the declaration screen https://pagopa.invisionapp.com/console/IO---Cashback---attivazione-ckfc5u1ej0j3j013m2kw7gwvp/ckfdr382k02gp012b6y1sdgxf/play
List of changes proposed in this pull request
DeclarationComponent
(graphical implementation) andDeclarationScreen
(link the graphical implementation with the business logic).CheckBox
InfoBox
ShowRoom
with new componentsFooterWithButtons
to supportdisabled
buttons (changed in this implementation, waiting to complete the core component that implements this functionality).bpd
section in localesHow to test