chore: [#174318137] Upgrade typescript to 3.9.7

package.json

@@ -175,7 +175,7 @@
     "ts-jest": "^25.1.0",
     "ts-node": "^7.0.1",
     "tslint": "5.20.0",
-    "typescript": "3.4.1"
+    "typescript": "^3.9.7"
   },
   "resolutions": {
     "@types/react": "16.7.18",

patches/@types+react-native-text-input-mask+0.7.2.patch

@@ -0,0 +1,23 @@
+diff --git a/node_modules/@types/react-native-text-input-mask/index.d.ts b/node_modules/@types/react-native-text-input-mask/index.d.ts
+index 4cf4b39..8eacdbc 100644
+--- a/node_modules/@types/react-native-text-input-mask/index.d.ts
++++ b/node_modules/@types/react-native-text-input-mask/index.d.ts
+@@ -4,6 +4,7 @@
+ // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
+ // TypeScript Version: 2.8
+
++import {MutableRefObject} from "react";
+ import * as React from "react";
+ import * as ReactNative from "react-native";
+
+@@ -221,6 +222,10 @@ export interface TextInputMaskProps extends ReactNative.ViewProps, ReactNative.T
+      * or set/update maxLength to prevent unwanted edits without flicker.
+      */
+     value?: string;
++
++    // Patch: Adding missing types ref and isNumericSecureKeyboard
++    ref?: ((instance: TextInputMask | null) => void) | MutableRefObject<TextInputMask | null> | null;
++    isNumericSecureKeyboard?: boolean,
+ }
+
+ export default class TextInputMask extends React.Component<TextInputMaskProps> { }

patches/patches.md

@@ -68,3 +68,10 @@ Created on **12/08/2020**
 
 #### Reason:
 - Use TouchableHighlight instead of TouchableNativeFeedback on Android sdk < 19 to avoid crash.
+
+
+### @types/react-native-text-input-mask+0.7.2
+Created on **13/08/2020**
+
+#### Reason:
+- Add missing props types for TextInputMaskProps.

ts/components/FlagSecure.tsx

@@ -32,7 +32,4 @@ const mapStateToProps = (state: GlobalState) => ({
   isAllowedSnapshotCurrentScreen: isAllowedSnapshotCurrentScreen(state)
 });
 
-export default connect(
-  mapStateToProps,
-  null
-)(FlagSecureComponent);
+export default connect(mapStateToProps)(FlagSecureComponent);

ts/components/screens/DarkLayout.tsx

@@ -1,15 +1,15 @@
 /**
  * A component to display a brandDarkGray background color on the screen using it
  */
-import { View } from "native-base";
+import { Content, View } from "native-base";
 import * as React from "react";
 import {
+  Animated,
   ImageSourcePropType,
-  RefreshControlProps,
   StyleProp,
+  StyleSheet,
   ViewStyle
 } from "react-native";
-import { StyleSheet } from "react-native";
 import LinearGradient from "react-native-linear-gradient";
 import { IconProps } from "react-native-vector-icons/Icon";
 import customVariables from "../../theme/variables";
@@ -41,7 +41,7 @@ type Props = Readonly<{
   footerContent?: React.ReactNode;
   contextualHelp?: ContextualHelpProps;
   contextualHelpMarkdown?: ContextualHelpPropsMarkdown;
-  contentRefreshControl?: React.ReactElement<RefreshControlProps>;
+  contentRefreshControl?: Animated.ComponentProps<Content>["refreshControl"];
   faqCategories?: ReadonlyArray<FAQsCategoriesType>;
   customGoBack?: React.ReactNode;
   gradientHeader?: boolean;

ts/components/screens/ScreenContent.tsx

@@ -1,16 +1,16 @@
 import { Content } from "native-base";
 import * as React from "react";
-import { NavigationEvents } from "react-navigation";
 
-import { RefreshControlProps, StyleProp, ViewStyle } from "react-native";
+import { StyleProp, ViewStyle } from "react-native";
+import { NavigationEvents } from "react-navigation";
 import { ComponentProps } from "../../types/react";
 import { ScreenContentHeader } from "./ScreenContentHeader";
 
 interface OwnProps {
   hideHeader?: boolean;
   contentStyle?: StyleProp<ViewStyle>;
   bounces?: boolean;
-  contentRefreshControl?: React.ReactElement<RefreshControlProps>;
+  contentRefreshControl?: ComponentProps<Content>["refreshControl"];
 }
 
 type Props = OwnProps & ComponentProps<typeof ScreenContentHeader>;

ts/components/wallet/WalletLayout.tsx

@@ -8,14 +8,9 @@
  * footer with a button for starting a new payment
  */
 
-import { Text, View } from "native-base";
+import { Content, Text, View } from "native-base";
 import * as React from "react";
-import {
-  RefreshControlProps,
-  StyleProp,
-  StyleSheet,
-  ViewStyle
-} from "react-native";
+import { Animated, StyleProp, StyleSheet, ViewStyle } from "react-native";
 import I18n from "../../i18n";
 import customVariables from "../../theme/variables";
 import { FAQsCategoriesType } from "../../utils/faq";
@@ -36,7 +31,7 @@ type Props = Readonly<{
   hideHeader?: boolean;
   footerContent?: React.ReactNode;
   contentStyle?: StyleProp<ViewStyle>;
-  refreshControl?: React.ReactElement<RefreshControlProps>;
+  refreshControl?: Animated.ComponentProps<Content>["refreshControl"];
   contextualHelp?: ContextualHelpProps;
   contextualHelpMarkdown?: ContextualHelpPropsMarkdown;
   faqCategories?: ReadonlyArray<FAQsCategoriesType>;

ts/features/bonusVacanze/store/sagas/activation/getBonusActivationSaga.ts

@@ -36,7 +36,11 @@ function* getBonusActivation(
     typeof BackendBonusVacanze
   >["getLatestBonusVacanzeFromId"],
   bonusId: string
-): IterableIterator<Effect | Either<Option<Error>, BonusActivationWithQrCode>> {
+): Generator<
+  Effect,
+  Either<Option<Error>, BonusActivationWithQrCode>,
+  SagaCallReturnType<typeof getLatestBonusVacanzeFromId>
+> {
   try {
     const getLatestBonusVacanzeFromIdResult: SagaCallReturnType<
       typeof getLatestBonusVacanzeFromId
@@ -49,32 +53,38 @@ function* getBonusActivation(
         switch (activation.status) {
           // processing -> polling should continue
           case BonusActivationStatusEnum.PROCESSING:
-            return left(none);
+            return left<Option<Error>, BonusActivationWithQrCode>(none);
           case BonusActivationStatusEnum.FAILED:
             // blocking error
-            return left(some(new Error("Bonus Activation failed")));
+            return left<Option<Error>, BonusActivationWithQrCode>(
+              some(new Error("Bonus Activation failed"))
+            );
           default:
             // active
-            return right(getLatestBonusVacanzeFromIdResult.value.value);
+            return right<Option<Error>, BonusActivationWithQrCode>(
+              getLatestBonusVacanzeFromIdResult.value.value
+            );
         }
       }
       // Request not found - polling must be stopped
       if (getLatestBonusVacanzeFromIdResult.value.status === 404) {
-        return left(some(new Error("Bonus Activation not found")));
+        return left<Option<Error>, BonusActivationWithQrCode>(
+          some(new Error("Bonus Activation not found"))
+        );
       }
       // polling should continue
-      return left(none);
+      return left<Option<Error>, BonusActivationWithQrCode>(none);
     } else {
       // we got some error on decoding, stop polling
-      return left(
+      return left<Option<Error>, BonusActivationWithQrCode>(
         some(
           Error(readablePrivacyReport(getLatestBonusVacanzeFromIdResult.value))
         )
       );
     }
   } catch (e) {
     // polling should continue
-    return left(none);
+    return left<Option<Error>, BonusActivationWithQrCode>(none);
   }
 }
 
@@ -87,8 +97,10 @@ export const bonusActivationSaga = (
     typeof BackendBonusVacanze
   >["getLatestBonusVacanzeFromId"]
 ) =>
-  function* startBonusActivationSaga(): IterableIterator<
-    Effect | ActionType<typeof activateBonusVacanze>
+  function* startBonusActivationSaga(): Generator<
+    Effect,
+    ActionType<typeof activateBonusVacanze>,
+    any
   > {
     try {
       const startBonusActivationProcedureResult: SagaCallReturnType<

ts/features/bonusVacanze/store/sagas/eligibility/getBonusEligibilitySaga.ts

@@ -58,7 +58,11 @@ function* getCheckBonusEligibilitySaga(
   getBonusEligibilityCheck: ReturnType<
     typeof BackendBonusVacanze
   >["getBonusEligibilityCheck"]
-): IterableIterator<Effect | Either<Option<Error>, EligibilityCheck>> {
+): Generator<
+  Effect,
+  Either<Option<Error>, EligibilityCheck>,
+  SagaCallReturnType<typeof getBonusEligibilityCheck>
+> {
   try {
     const eligibilityCheckResult: SagaCallReturnType<
       typeof getBonusEligibilityCheck
@@ -68,18 +72,18 @@ function* getCheckBonusEligibilitySaga(
       // 200 -> we got the check result, polling must be stopped
       if (eligibilityCheckResult.value.status === 200) {
         const check = eligibilityCheckResult.value.value;
-        return right(check);
+        return right<Option<Error>, EligibilityCheck>(check);
       }
       // polling should continue
-      return left(none);
+      return left<Option<Error>, EligibilityCheck>(none);
     } else {
       // we got some error on decoding, stop polling
-      return left(
+      return left<Option<Error>, EligibilityCheck>(
         some(Error(readablePrivacyReport(eligibilityCheckResult.value)))
       );
     }
   } catch (e) {
-    return left(none);
+    return left<Option<Error>, EligibilityCheck>(none);
   }
 }
 
@@ -105,8 +109,10 @@ export const bonusEligibilitySaga = (
     typeof BackendBonusVacanze
   >["getBonusEligibilityCheck"]
 ) =>
-  function* getBonusEligibilitySaga(): IterableIterator<
-    Effect | ActionType<typeof checkBonusVacanzeEligibility>
+  function* getBonusEligibilitySaga(): Generator<
+    Effect,
+    ActionType<typeof checkBonusVacanzeEligibility>,
+    any
   > {
     try {
       const startEligibilityResult: SagaCallReturnType<

ts/sagas/backendInfo.ts

@@ -21,7 +21,11 @@ const BACKEND_INFO_LOAD_INTERVAL = 60 * 60 * 1000;
 // retry loading backend info every 10 seconds on error
 const BACKEND_INFO_RETRY_INTERVAL = 10 * 1000;
 
-function* backendInfoWatcher(): IterableIterator<Effect> {
+function* backendInfoWatcher(): Generator<
+  Effect,
+  void,
+  SagaCallReturnType<typeof getServerInfo>
+> {
   const backendPublicClient = BackendPublicClient(apiUrlPrefix);
 
   function getServerInfo(): Promise<
@@ -36,9 +40,7 @@ function* backendInfoWatcher(): IterableIterator<Effect> {
 
   while (true) {
     try {
-      const backendInfoResponse: SagaCallReturnType<
-        typeof getServerInfo
-      > = yield call(getServerInfo);
+      const backendInfoResponse = yield call(getServerInfo);
       if (
         backendInfoResponse.isRight() &&
         backendInfoResponse.value.status === 200

ts/sagas/backendStatus.ts

@@ -16,12 +16,9 @@ const BACKEND_SERVICES_STATUS_FAILURE_INTERVAL = (10 * 1000) as Millisecond;
 // Return true if it has information (200) false otherwise
 export function* backendStatusSaga(
   getServicesStatus: ReturnType<typeof CdnBackendStatusClient>["getStatus"]
-): IterableIterator<Effect | boolean> {
+): Generator<Effect, boolean, SagaCallReturnType<typeof getServicesStatus>> {
   try {
-    const response: SagaCallReturnType<typeof getServicesStatus> = yield call(
-      getServicesStatus,
-      {}
-    );
+    const response = yield call(getServicesStatus, {});
     if (response.isRight() && response.value.status === 200) {
       yield put(backendStatusLoadSuccess(response.value.value));
       return true;
@@ -40,7 +37,7 @@ export function* backendStatusSaga(
  */
 export function* backendStatusWatcherLoop(
   getStatus: ReturnType<typeof CdnBackendStatusClient>["getStatus"]
-): IterableIterator<Effect> {
+) {
   // check backend status periodically
   while (true) {
     const response: SagaCallReturnType<typeof backendStatusSaga> = yield call(

ts/sagas/contentLoaders.ts

@@ -140,7 +140,11 @@ function* watchServiceMetadataLoadSaga(
 function* fetchMunicipalityMetadata(
   getMunicipality: ReturnType<typeof ContentClient>["getMunicipality"],
   codiceCatastale: CodiceCatastale
-): IterableIterator<Effect | Either<Error, MunicipalityMedadata>> {
+): Generator<
+  Effect,
+  Either<Error, MunicipalityMedadata>,
+  SagaCallReturnType<typeof getMunicipality>
+> {
   try {
     const response: SagaCallReturnType<typeof getMunicipality> = yield call(
       getMunicipality,
@@ -153,9 +157,9 @@ function* fetchMunicipalityMetadata(
     if (response.value.status !== 200) {
       throw Error(`response status ${response.value.status}`);
     }
-    return right(response.value.value);
+    return right<Error, MunicipalityMedadata>(response.value.value);
   } catch (error) {
-    return left(error);
+    return left<Error, MunicipalityMedadata>(error);
   }
 }
 

ts/sagas/identification.ts

@@ -47,7 +47,11 @@ type ResultAction =
   | ActionType<typeof identificationForceLogout>
   | ActionType<typeof identificationSuccess>;
 // Wait the identification and return the result
-function* waitIdentificationResult(): Iterator<Effect | IdentificationResult> {
+function* waitIdentificationResult(): Generator<
+  Effect,
+  void | IdentificationResult,
+  any
+> {
   const resultAction: ResultAction = yield take([
     getType(identificationCancel),
     getType(identificationPinReset),
@@ -136,7 +140,7 @@ export function* startAndReturnIdentificationResult(
 function* startAndHandleIdentificationResult(
   pin: PinString,
   identificationRequestAction: ActionType<typeof identificationRequest>
-): IterableIterator<Effect> {
+) {
   yield put(
     identificationStart(
       pin,

ts/sagas/instabug.ts

@@ -4,7 +4,6 @@ import {
   instabugUnreadMessagesLoaded,
   updateInstabugUnreadMessages
 } from "../store/actions/instabug";
-import { SagaCallReturnType } from "../types/utils";
 
 const loadInstabugUnreadMessages = () => {
   return new Promise<number>(resolve => {
@@ -31,10 +30,8 @@ function* watchInstabugSaga(): IterableIterator<Effect> {
   }
 }
 
-function* updateInstabugBadgeSaga(): IterableIterator<Effect> {
-  const repliesCount: SagaCallReturnType<
-    typeof loadInstabugUnreadMessages
-  > = yield call(loadInstabugUnreadMessages);
+function* updateInstabugBadgeSaga(): Generator<any, void, number> {
+  const repliesCount = yield call(loadInstabugUnreadMessages);
   yield put(instabugUnreadMessagesLoaded(repliesCount));
 }
 

ts/sagas/installation.ts

@@ -12,8 +12,10 @@ import { deletePin } from "../utils/keychain";
  * This generator function removes user data from previous application
  * installation
  */
-export function* previousInstallationDataDeleteSaga(): IterableIterator<
-  Effect
+export function* previousInstallationDataDeleteSaga(): Generator<
+  Effect,
+  void,
+  boolean
 > {
   const isFirstRunAfterInstall: ReturnType<
     typeof isFirstRunAfterInstallSelector