[#172992652] Activate bonus screen #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziofff
requested review from
francescopersico,
matteodesanti and
Undermaken
as code owners
Affected stories
Generated by 🚫 dangerJS |
Undermaken
suggested changes
May 28, 2020
ts/features/bonusVacanze/screens/ActivateBonus/ActivateBonusScreen.tsx
Outdated
Show resolved
Hide resolved
ts/features/bonusVacanze/screens/ActivateBonus/ActivateBonusScreen.tsx
Outdated
Show resolved
Hide resolved
ts/features/bonusVacanze/screens/ActivateBonus/ActivateBonusComponent.tsx
Outdated
Show resolved
Hide resolved
… into 172992652-activate-bonus-screen
fabriziofff
commented
May 28, 2020
|
|
||
| const mapStateToProps = (_: GlobalState) => ({ | ||
| // TODO: link with the right reducer | ||
| bonusVacanze: mockedBonus, |
There was a problem hiding this comment.
@Undermaken Are we sure to use this data model here? In this phase we should have only the response from /eligibility with the payload with values family_members, max_amount and max_tax_benefit. Seems to me that the model BonusVacanzaMock represents an already request bonus.
There was a problem hiding this comment.
@fabriziofff Yes, you are totally right.
I lost the point where we are.
At this point we should have something like this
{
"family_members": [
{
"name": "Mario",
"surname": "Rossi",
"fiscal_code": "EFCMZZ80A12L720R"
},
{
"name": "Giulia",
"surname": "Rossi",
"fiscal_code": "CDCMQQ81A12L721R"
},
{
"name": "Piero",
"surname": "Rossi",
"fiscal_code": "ABCMYY82A12L722R"
}
],
"max_amount": 50000,
"max_tax_benefit": 3000,
"id": "76d02f6d-ca02-4b1c-8b6a-4b8ca71d6293",
"status": "ELIGIBLE"
}Please could you revert?
Undermaken
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr depends on (#1846).
Short description:
This pr adds the screen that allow to see:
And allows to:
List of changes proposed in this pull request:
ts/features/bonusVacanze/screens/ActivateBonus/ActivateBonusComponent.tsxa component that implements all the graphic required by the screen.ts/features/bonusVacanze/screens/ActivateBonus/ActivateBonusScreen.tsxthat uses theActivateBonusComponentand tie it with the business logic.