[#172076080] Added delay between incorrect pin insertion attempts #1711
Conversation
…lay-between-wrong-pin-try
…lay-between-wrong-pin-try
…lay-between-wrong-pin-try
# Conflicts: # ts/IdentificationModal.tsx
Affected stories
Generated by 🚫 dangerJS |
fabriziofff
requested review from
francescopersico,
matteodesanti and
Undermaken
as code owners
…for too many attempts
| wrongCode: Codice errato | ||
| remainingAttempts: Ti rimangono {{attempts}} tentativi. | ||
| remainingAttemptSingle: Ti rimane {{attempts}} tentativo. | ||
| tooManyAttempts: Troppi tentativi di inserimento errati. |
There was a problem hiding this comment.
| tooManyAttempts: Troppi tentativi di inserimento errati. | |
| tooManyAttempts: Hai esaurito i tentativi di inserimento del tuo Codice di sblocco. |
According to the mockup
There was a problem hiding this comment.
waiting for the updated text to complete this part.
There was a problem hiding this comment.
I guess it's ready https://projects.invisionapp.com/share/SCOVFJ2D36K#/screens/413902179
There was a problem hiding this comment.
The text has not changed, it is the same as it was at the beginning ("Hai esaurito i tentativi di inserimento del tuo codice di sblocco" is not true).
There was a problem hiding this comment.
@fabriziofff are you sure? I check it right now and I see
tooManyAttempts: Troppi tentativi di inserimento errati.
It is also listed here in files changes
I checked it on this commit 9591067
There was a problem hiding this comment.
I was talking about the invision file and the texts. In the last sprint review we agreed on a textual review because neither my change "Troppi tentativi di inserimento errati" nor "Hai esaurito i tentativi di inserimento del tuo codice di sblocco" were good and I was waiting for the updated version.
if the review is no longer needed, I can change it immediately with the first version.
There was a problem hiding this comment.
I completely removed it from my mind!
Since this is a minor change we can update it in another stor/PR
| remainingAttempts: Ti rimangono {{attempts}} tentativi. | ||
| remainingAttemptSingle: Ti rimane {{attempts}} tentativo. | ||
| tooManyAttempts: Troppi tentativi di inserimento errati. | ||
| waitMessage: "Riprova tra:" |
There was a problem hiding this comment.
| waitMessage: "Riprova tra:" | |
| waitMessage: "Chiudi l’applicazione o riprova tra:" |
I guess this message could be more appropriate. (sorry for the rollback 😈)
Isn't it?
…lay-between-wrong-pin-try
| wrongCode: Codice errato | ||
| remainingAttempts: Ti rimangono {{attempts}} tentativi. | ||
| remainingAttemptSingle: Ti rimane {{attempts}} tentativo. | ||
| tooManyAttempts: Troppi tentativi di inserimento errati. |
There was a problem hiding this comment.
I guess it's ready https://projects.invisionapp.com/share/SCOVFJ2D36K#/screens/413902179
ts/IdentificationModal.tsx
Outdated
| ) { | ||
| this.maybeTriggerFingerprintRequest({ | ||
| updateBiometrySupportProp: | ||
| prevProps.appState !== "active" && this.props.appState === "active" | ||
| }); | ||
| } | ||
|
|
||
| const previousAttempts = prevProps.identificationFailState |
There was a problem hiding this comment.
Since it could have or not a value, could be this statement more expressive?
prevProps.identificationFailState.fold(
undefined,
s => s.remainingAttempts
);…lay-between-wrong-pin-try
Short description:
This pr changes the behaviour of the identification phase when too many wrong attempts are made.
The new behavior follows the following rules:
Wrong attempts sequence:
Hard logout after last try:
List of changes proposed in this pull request:
IdentificationLockModaldisplayed to lock the application during the waiting phase.IdentificationModalto support the new logic.PinPadto support the rendering of the "remaining attempts block"identificationFailureaction toIdentificationActions to model the new action of failure of pin insertion.identificationsection, adding two separate sub-sections:progresscontaining all the information on the identification "state" andfailcontaining all the information related to the fail pin data. Thefailsection is now persisted.ts/store/reducers/identification.tsto support the new actions and store.ts/sagas/identification.tsto support the forceLogout action.ts/store/transforms/dateISO8601Tranform.tsto support the serialization of aDatefor the storeidentification.fail.nextLegalAttempt. [TODO: in this phase I've just added the rules to serialize the fields as data, in the future could be a good idea to change the file in order to support in a generic and parametric way the serialization of a generic field]How to test:
When a pin is requested (application open or payment) insert a wrong pin multiple time.