fix(Bonus Pagamenti Digitali): [#176551362] Not all the getWalletV2 call are tracked #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziofff
requested review from
CrisTofani,
debiff and
Undermaken
as code owners
pagopa-github-bot
changed the title
Affected stories
|
Undermaken
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pr changes the tracking for the
/v2/walletin order to track all the calls.Atm, only the actions
fetchWalletsFailure,fetchWalletsRequestandfetchWalletsSuccessare tracked, but the functiongetWalletsV2can be also called without usingfetchWalletsRequest; this generates an incorrect and untrue subset of data.List of changes proposed in this pull request
fetchWalletsFailure,fetchWalletsRequestandfetchWalletsSuccess.getWalletsV2in order to track all the function invocation.