fix(Bonus Pagamenti Digitali): [#176551362] Not all the getWalletV2 c…

…all are tracked (#2815) * [#176551362] remove old analytics * [#176551362] track wallet in saga Co-authored-by: Matteo Boschi <[email protected]>
pagopa · Feb 12, 2021 · a286f21 · a286f21
1 parent 5aca618
commit a286f21
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/ts/sagas/wallet/pagopaApis.ts b/ts/sagas/wallet/pagopaApis.ts
@@ -5,6 +5,7 @@ import { ActionType } from "typesafe-actions";
 import { Either, left, right } from "fp-ts/lib/Either";
 import { BackendClient } from "../../api/backend";
 import { PaymentManagerClient } from "../../api/pagopa";
+import { mixpanelTrack } from "../../mixpanel";
 import {
   paymentAttiva,
   paymentCheck,
@@ -72,13 +73,17 @@ export function* getWalletsV2(
   pmSessionManager: SessionManager<PaymentManagerToken>
 ): Generator<Effect, Either<Error, ReadonlyArray<Wallet>>, any> {
   try {
+    void mixpanelTrack("WALLETS_LOAD_REQUEST");
     const request = pmSessionManager.withRefresh(pagoPaClient.getWalletsV2);
     const getResponse: SagaCallReturnType<typeof request> = yield call(request);
     if (getResponse.isRight()) {
       if (getResponse.value.status === 200) {
         const wallets = (getResponse.value.value.data ?? []).map(
           convertWalletV2toWalletV1
         );
+        void mixpanelTrack("WALLETS_LOAD_SUCCESS", {
+          count: wallets.length
+        });
         yield put(fetchWalletsSuccess(wallets));
         return right<Error, ReadonlyArray<Wallet>>(wallets);
       } else {
@@ -91,6 +96,11 @@ export function* getWalletsV2(
     // this is required to handle 401 response from PM
     // On 401 response sessionManager retries for X attempts to get a valid session
     // If it exceeds a fixed threshold of attempts a max retries error will be dispatched
+
+    void mixpanelTrack("WALLETS_LOAD_FAILURE", {
+      reason: error.message
+    });
+
     if (isTimeoutError(getNetworkError(error))) {
       // check if also the IO session is expired
       yield put(checkCurrentSession.request());
@@ -676,9 +686,9 @@ export function* paymentAttivaRequestHandler(
         paymentActivationsPostRequest: {
           rptId: RptIdFromString.encode(action.payload.rptId),
           codiceContestoPagamento:
-          action.payload.verifica.codiceContestoPagamento,
+            action.payload.verifica.codiceContestoPagamento,
           importoSingoloVersamento:
-          action.payload.verifica.importoSingoloVersamento
+            action.payload.verifica.importoSingoloVersamento
         },
         test: isPagoPATestEnabled
       }

diff --git a/ts/store/middlewares/analytics.ts b/ts/store/middlewares/analytics.ts
@@ -116,9 +116,6 @@ import {
   deleteWalletFailure,
   deleteWalletRequest,
   deleteWalletSuccess,
-  fetchWalletsFailure,
-  fetchWalletsRequest,
-  fetchWalletsSuccess,
   payCreditCardVerificationFailure,
   payCreditCardVerificationRequest,
   payCreditCardVerificationSuccess,
@@ -194,7 +191,6 @@ const trackAction = (mp: NonNullable<typeof mixpanel>) => (
     // wallets success / services load requests
     //
     case getType(loadServicesDetail):
-    case getType(fetchWalletsSuccess):
       return mp.track(action.type, {
         count: action.payload.length
       });
@@ -294,7 +290,6 @@ const trackAction = (mp: NonNullable<typeof mixpanel>) => (
     case getType(loginFailure):
     case getType(loadMessages.failure):
     case getType(loadVisibleServices.failure):
-    case getType(fetchWalletsFailure):
     case getType(payCreditCardVerificationFailure):
     case getType(deleteWalletFailure):
     case getType(setFavouriteWalletFailure):
@@ -365,7 +360,6 @@ const trackAction = (mp: NonNullable<typeof mixpanel>) => (
     case getType(loadServiceMetadata.request):
     case getType(loadServiceMetadata.success):
     // wallet
-    case getType(fetchWalletsRequest):
     case getType(addWalletCreditCardInit):
     case getType(addWalletCreditCardRequest):
     case getType(addWalletNewCreditCardSuccess):