-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Carta Giovani Nazionale): [#176870737] Implements CGN Activation Workflow by using the specific GET Status API for polling #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matteo Boschi <[email protected]>
Co-authored-by: Matteo Boschi <[email protected]>
Co-authored-by: fabriziofff <[email protected]>
Co-authored-by: fabriziofff <[email protected]>
Co-authored-by: fabriziofff <[email protected]>
Co-authored-by: fabriziofff <[email protected]>
fabriziofff
reviewed
Feb 26, 2021
ts/features/bonus/cgn/saga/networking/activation/getBonusActivationSaga.ts
Show resolved
Hide resolved
fabriziofff
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PR DEPENDS ON #2773
Short description
This PR changes the API for polling and receive the updated status of the CGN Activation during the onboarding funnel
Previous activation workflow and API
/cgn/activation
via POST request to ask for activation to start/cgn/status
via GET to know the activation statusNew activation workflow and API
/cgn/activation
via POST to ask for activation to start/cgn/activation
via GET request to know the activation statusIf status is
ERROR
orCOMPLETED
stop polling, throws an error or dispatch success action, any other case keep polling