Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#176272983] Ranking not ready component & bottomsheet #2641

Merged
merged 38 commits into from
Dec 29, 2020

Conversation

fabriziofff
Copy link
Contributor

@fabriziofff fabriziofff commented Dec 23, 2020

This pr depends on #2633

Short description

This pr adds the handling of the "ranking not ready". This case can occur on two occasions:

  1. Bpd doesn't have yet enough transactions to provide a ranking
  2. The config bpd_ranking is false | undefined

List of changes proposed in this pull request

  • Added SuperCashbackRankingNotReadycomponent
  • Changed SuperCashbackRankingSummary in order to choose the right SuperCashback ranking representation, using the function shouldDisplayRankingReady
  • Added RankingNotReady bottomsheet

How to test

  • run ts/features/bonus/bpd/screens/details/components/summary/__test__/bpdSummaryComponent.test.tsx
  • run ts/features/bonus/bpd/screens/details/components/summary/__test__/rankingNotReady.test.tsx

…528-supercashback-graphical-component-and-textual-summary-update
…back-graphical-component-and-textual-summary-update' into 176191528-supercashback-graphical-component-and-textual-summary-update
…back-graphical-component-and-textual-summary-update' into 176191528-supercashback-graphical-component-and-textual-summary-update
…528-supercashback-graphical-component-and-textual-summary-update
…t-and-textual-summary-update' into 176272983-ranking-not-ready
@fabriziofff fabriziofff changed the title [#176272983] ranking not ready [#176272983] Ranking not ready Dec 23, 2020
@pagopa-github-bot pagopa-github-bot changed the title [#176272983] Ranking not ready feat(Bonus Pagamenti Digitali): [#176272983] Ranking not ready Dec 23, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 23, 2020

Affected stories

  • 🌟 #176272983: Come CIT, quando la classifica non è ancora stabile, voglio visualizzare un item di anteprima che mi avvisi

Generated by 🚫 dangerJS against 350c583

@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #2641 (350c583) into master (214f241) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2641      +/-   ##
==========================================
+ Coverage   51.08%   51.19%   +0.11%     
==========================================
  Files         721      723       +2     
  Lines       20540    20562      +22     
  Branches     3951     3633     -318     
==========================================
+ Hits        10492    10527      +35     
+ Misses      10004     9991      -13     
  Partials       44       44              
Impacted Files Coverage Δ
...details/components/summary/BpdSummaryComponent.tsx 92.00% <100.00%> (ø)
...nts/summary/ranking/RankingNotReadyBottomSheet.tsx 100.00% <100.00%> (ø)
...ts/summary/ranking/SuperCashbackRankingSummary.tsx 100.00% <100.00%> (ø)
ts/store/reducers/__mock__/backendStatus.ts 100.00% <100.00%> (ø)
ts/utils/bottomSheet.ts 45.94% <0.00%> (+13.51%) ⬆️
...sVacanze/components/hooks/useHardwareBackButton.ts 75.00% <0.00%> (+43.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 214f241...350c583. Read the comment docs.

@fabriziofff fabriziofff marked this pull request as ready for review December 23, 2020 19:25
@fabriziofff fabriziofff changed the title feat(Bonus Pagamenti Digitali): [#176272983] Ranking not ready feat(Bonus Pagamenti Digitali): [#176272983] Ranking not ready component & bottomsheet Dec 23, 2020
@Undermaken Undermaken merged commit afcb441 into master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants