-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Bonus Pagamenti Digitali): [#176272983] Ranking not ready component & bottomsheet #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…528-supercashback-graphical-component-and-textual-summary-update
…t-and-textual-summary-update
…back-graphical-component-and-textual-summary-update' into 176191528-supercashback-graphical-component-and-textual-summary-update
…t-and-textual-summary-update
…back-graphical-component-and-textual-summary-update' into 176191528-supercashback-graphical-component-and-textual-summary-update
…528-supercashback-graphical-component-and-textual-summary-update
…t-and-textual-summary-update' into 176272983-ranking-not-ready
fabriziofff
changed the title
[#176272983] ranking not ready
[#176272983] Ranking not ready
Dec 23, 2020
pagopa-github-bot
changed the title
[#176272983] Ranking not ready
feat(Bonus Pagamenti Digitali): [#176272983] Ranking not ready
Dec 23, 2020
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2641 +/- ##
==========================================
+ Coverage 51.08% 51.19% +0.11%
==========================================
Files 721 723 +2
Lines 20540 20562 +22
Branches 3951 3633 -318
==========================================
+ Hits 10492 10527 +35
+ Misses 10004 9991 -13
Partials 44 44
Continue to review full report at Codecov.
|
fabriziofff
changed the title
feat(Bonus Pagamenti Digitali): [#176272983] Ranking not ready
feat(Bonus Pagamenti Digitali): [#176272983] Ranking not ready component & bottomsheet
Dec 23, 2020
…t-and-textual-summary-update
…t-and-textual-summary-update
…t-and-textual-summary-update
…t-and-textual-summary-update
…ical-component-and-textual-summary-update
…t-and-textual-summary-update' into 176272983-ranking-not-ready
Undermaken
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr depends on #2633
Short description
This pr adds the handling of the "ranking not ready". This case can occur on two occasions:
bpd_ranking
isfalse | undefined
List of changes proposed in this pull request
SuperCashbackRankingNotReady
componentSuperCashbackRankingSummary
in order to choose the right SuperCashback ranking representation, using the functionshouldDisplayRankingReady
RankingNotReady
bottomsheetHow to test
ts/features/bonus/bpd/screens/details/components/summary/__test__/bpdSummaryComponent.test.tsx
ts/features/bonus/bpd/screens/details/components/summary/__test__/rankingNotReady.test.tsx