Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Bonus Pagamenti Digitali): [#175934342] Onboarding credit card failure instead of success #2459

Merged
merged 6 commits into from
Dec 1, 2020

Conversation

Undermaken
Copy link
Contributor

@Undermaken Undermaken commented Nov 30, 2020

Short description

Even if the credit card onboarding goes fine, the relative attempt remains in failure state
This is because the BPD flow returns before the success action is dispatched

wallet/ ? / faq about payment method onboarding

@pagopa-github-bot pagopa-github-bot changed the title [#175934342] Onboarding credit card failure instead of success fix(Bonus Pagamenti Digitali): [#175934342] Onboarding credit card failure instead of success Nov 30, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 30, 2020

Affected stories

  • 🐞 #175934342: [major] Il tentativo di aggiunta di pagamento risulta fallito anche se ha avuto successo

Generated by 🚫 dangerJS against 2607327

@Undermaken Undermaken marked this pull request as ready for review November 30, 2020 14:19
@codecov-io
Copy link

codecov-io commented Dec 1, 2020

Codecov Report

Merging #2459 (2607327) into master (4865bb1) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2459   +/-   ##
=======================================
  Coverage   50.47%   50.47%           
=======================================
  Files         697      697           
  Lines       19622    19622           
  Branches     3797     3799    +2     
=======================================
  Hits         9904     9904           
  Misses       9672     9672           
  Partials       46       46           
Impacted Files Coverage Δ
ts/sagas/wallet.ts 22.99% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4865bb1...2607327. Read the comment docs.

@Undermaken Undermaken merged commit 6ca2db2 into master Dec 1, 2020
@Undermaken Undermaken deleted the 175934342-fix-false-negative branch December 1, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants