Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#175488816] change payment label to wallet #2356

Merged
merged 15 commits into from
Nov 10, 2020

Conversation

debiff
Copy link
Contributor

@debiff debiff commented Nov 9, 2020

Short description

This PR rename every occurrence of the Payment section in Wallet

List of changes proposed in this pull request

  • Renamed menu item
  • Renamed title section
  • Renamed occurrence in BONUS_REQUEST_INFORMATION
  • Renamed occurrence in MESSAGE_DETAILS
  • Renamed occurrence in BONUS_ACTIVATION_EXISTS

In the contextual help:

  • Renamed occurrence in WALLET_HOME
  • Renamed occurrence in WALLET_TRANSACTION_DETAILS
  • Renamed occurrence in WALLET_LIST
  • Renamed occurrence in WALLET_CARD_TRANSACTION
  • Renamed occurrence in WALLET_ADD_PAYMENT_METHOD
  • Renamed occurrence in WALLET_ADD_CARD
  • Renamed occurrence in WALLET_CONFIRM_CARD_DETAILS
  • Renamed occurrence in BONUS_ACTIVE_DETAIL_SCREEN
  • Renamed occurrence in BONUS_AVAILABLE_LIST

@pagopa-github-bot pagopa-github-bot changed the title [#175488816] change payment label to wallet feat: [#175488816] change payment label to wallet Nov 9, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 9, 2020

Affected stories

  • 🌟 #175488816: Come CIT voglio che la sezione in cui trovo i miei metodi di pagamento e i miei bonus si chiami "Portafoglio"

Generated by 🚫 dangerJS against 0188313

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@878f7df). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2356   +/-   ##
=========================================
  Coverage          ?   48.83%           
=========================================
  Files             ?      631           
  Lines             ?    17717           
  Branches          ?     3205           
=========================================
  Hits              ?     8652           
  Misses            ?     9023           
  Partials          ?       42           
Impacted Files Coverage Δ
ts/components/screens/BaseScreenComponent.tsx 24.05% <0.00%> (ø)
...atures/bonus/bonusVacanze/data/availableBonuses.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 878f7df...0b8392c. Read the comment docs.

@@ -170,6 +176,20 @@ class BaseScreenComponent extends React.PureComponent<Props, State> {
customHandledLink.map(link => handleItemOnPress(link)());
};

private chMarkdown = (chTitle: string, chBody: string) => ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not anymore after this PR #2363

@Undermaken Undermaken merged commit 9b3e602 into master Nov 10, 2020
@Undermaken Undermaken deleted the 175488816-change-payment-label-to-wallet branch November 10, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants