fix: [#174949682] Fix duplicate keys on Keypad #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debiff
requested review from
CrisTofani,
fabriziofff and
francescopersico
as code owners
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2234 +/- ##
========================================
Coverage 47.47% 47.47%
========================================
Files 515 515
Lines 15193 15193
Branches 3073 2821 -252
========================================
Hits 7213 7213
Misses 7939 7939
Partials 41 41
Continue to review full report at Codecov.
|
|
This PR lgtm |
CrisTofani
approved these changes
Sep 28, 2020
Co-authored-by: Cristiano Tofani <[email protected]>
Undermaken
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR fix the warning related to the duplicate keys on the Keypad component on the app authentication and in the app insertion screens.
List of changes proposed in this pull request
Use pin label as key.